Skip to content

Remove script preloading #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ascorbic opened this issue May 11, 2022 · 2 comments · Fixed by #134
Closed

Remove script preloading #127

ascorbic opened this issue May 11, 2022 · 2 comments · Fixed by #134
Assignees
Labels
good first issue Good for newcomers

Comments

@ascorbic
Copy link
Contributor

ascorbic commented May 11, 2022

Gatsby 4.14 removes most preloading of assets, because it turns out that it was affecting performance by interfering with the loading of more important assets like images. As well as the changes in Gatsby core, the update also removed all preload header handling from the Gatsby Cloud plugin. We should do the same.

@mwskwong
Copy link

mwskwong commented May 12, 2022

Agree. BTW, if I'm not mistaken, it is equivalent to set mergeLinkHeaders to false. If that's the case, all we have to do is change the default value of mergeLinkHeaders.

@ascorbic
Copy link
Contributor Author

Effectively yes, but as it seems like it's a footgun it's better if we remove it entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants