Merge pull request #352 from mozilla/clippy-remove-wrong_self_convention-2

baumanj · web-flow · commit df0591f75165 · 2021-10-27T12:48:22.000-07:00
Remove obsolete clippy::wrong_self_convention, again
diff --git a/mp4parse/src/lib.rs b/mp4parse/src/lib.rs
@@ -51,8 +51,6 @@ const MIF1_BRAND: FourCC = FourCC { value: *b"mif1" };
 /// A trait to indicate a type can be infallibly converted to `u64`.
 /// This should only be implemented for infallible conversions, so only unsigned types are valid.
 trait ToU64 {
-    // Remove when https://github.com/rust-lang/rust-clippy/issues/6727 is resolved
-    #[allow(clippy::wrong_self_convention)]
     fn to_u64(self) -> u64;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,6 @@ const MIF1_BRAND: FourCC = FourCC { value: *b"mif1" };`
`51`	`51`	/// A trait to indicate a type can be infallibly converted to `u64`.
`52`	`52`	`/// This should only be implemented for infallible conversions, so only unsigned types are valid.`
`53`	`53`	`trait ToU64 {`
`54`		`- // Remove when https://github.com/rust-lang/rust-clippy/issues/6727 is resolved`
`55`		`- #[allow(clippy::wrong_self_convention)]`
`56`	`54`	`fn to_u64(self) -> u64;`
`57`	`55`	`}`
`58`	`56`