Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Get hot reloading to work for development #275

Closed
kumar303 opened this issue Feb 25, 2019 · 1 comment
Closed

Get hot reloading to work for development #275

kumar303 opened this issue Feb 25, 2019 · 1 comment
Assignees
@willdurand
Labels
component:code_quality priority:p3 state:pull_request_ready
Milestone
2019.04.11

Comments

@kumar303
Copy link
Contributor

Describe the problem and steps to reproduce it:

  • Start all development processes with yarn dev
  • Open Redux Developer Tools
  • Sign in to the app
  • Sign out
  • Open components/App/index.tsx and edit the text saying "Please log in..."

What happened?

The page does a full refresh to show the new text. You lose all of your Redux state.

What did you expect to happen?

The App component should be hot reloaded to show the new text, preserving Redux state.

Anything else we should know?

Upstream issue: facebook/create-react-app#6503
@kumar303 kumar303 mentioned this issue Feb 25, 2019
Closed
@willdurand willdurand mentioned this issue Apr 9, 2019
Merged
@willdurand willdurand self-assigned this Apr 9, 2019
@willdurand
Copy link
Member

I don't think this is blocked by anything. For some reason, it seems to work 😅

@willdurand willdurand added this to the 2019.04.11 milestone Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@willdurand willdurand

Labels
component:code_quality priority:p3 state:pull_request_ready
Projects
None yet
Milestone
2019.04.11
Development

No branches or pull requests
2 participants
@kumar303 @willdurand