Skip to content

Commit c547a15

Browse files
committed
another set of changes to resolve minor issues
Signed-off-by: Medha Tiwari <[email protected]>
1 parent 02579c1 commit c547a15

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

src/MongoDB.Bson/Serialization/BinaryVectorReader.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ private static float[] ReadSinglesArrayLittleEndian(ReadOnlySpan<byte> span)
127127
else
128128
{
129129
var count = span.Length / 4;
130-
result = new float[count];
131-
for (int i = 0; i < count; i++)
130+
result = new float[count];
131+
for (int i = 0; i < count; i++)
132132
{
133133
result[i] = BinaryPrimitivesCompat.ReadSingleLittleEndian(span.Slice(i * 4, 4));
134134
}

src/MongoDB.Bson/Serialization/BinaryVectorWriter.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,8 @@ public static byte[] WriteToBytes<TItem>(ReadOnlySpan<TItem> vectorData, BinaryV
3939
switch (binaryVectorDataType)
4040
{
4141
case BinaryVectorDataType.Float32:
42-
byte[] result;
4342
var length = vectorData.Length * 4;
44-
result = new byte[2 + length];
43+
var result = new byte[2 + length];
4544
result[0] = (byte)binaryVectorDataType;
4645
result[1] = padding;
4746

tests/MongoDB.Bson.Tests/IO/BinaryPrimitivesCompatTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ public void ReadSingleLittleEndian_should_throw_on_insufficient_length()
3737
var exception = Record.Exception(() =>
3838
BinaryPrimitivesCompat.ReadSingleLittleEndian(shortBuffer));
3939

40-
exception.Should().BeOfType<ArgumentOutOfRangeException>();
41-
exception.Message.Should().Contain("length");
40+
var e = exception.Should().BeOfType<ArgumentOutOfRangeException>().Subject;
41+
e.ParamName.Should().Be("length");
4242
}
4343

4444
[Fact]
@@ -48,8 +48,8 @@ public void WriteSingleLittleEndian_should_throw_on_insufficient_length()
4848
var exception = Record.Exception(() =>
4949
BinaryPrimitivesCompat.WriteSingleLittleEndian(shortBuffer, 1.23f));
5050

51-
exception.Should().BeOfType<ArgumentOutOfRangeException>();
52-
exception.Message.Should().Contain("length");
51+
var e = exception.Should().BeOfType<ArgumentOutOfRangeException>().Subject;
52+
e.ParamName.Should().Be("length");
5353
}
5454

5555
[Fact]

0 commit comments

Comments
 (0)