Skip to content

Commit 5cb6949

Browse files
author
Tracy Boehrer
committed
Merge branch 'main' into releases/4.14
# Conflicts: # libraries/botbuilder-core/botbuilder/core/cloud_adapter_base.py
2 parents 83bc043 + e61d4b3 commit 5cb6949

File tree

15 files changed

+31
-27
lines changed

15 files changed

+31
-27
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
aiohttp==3.8.5
1+
aiohttp==3.9.0
22
pyslack
33
botbuilder-core==4.15.0
44
slackclient

libraries/botbuilder-ai/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
msrest==0.6.*
1+
msrest== 0.7.*
22
botbuilder-schema==4.15.0
33
botbuilder-core==4.15.0
44
requests==2.31.0

libraries/botbuilder-applicationinsights/django_tests/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def getid(request, id):
5252

5353
@api_view(["POST"])
5454
def returncode(request, id):
55-
return HttpResponse("Status code set to %s" % id, status=int(id))
55+
return HttpResponse("returncode", status=int(id))
5656

5757

5858
@api_view(["POST"])
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
msrest==0.6.*
1+
msrest== 0.7.*
22
botbuilder-core==4.15.0
33
aiounittest==1.3.0

libraries/botbuilder-core/botbuilder/core/cloud_adapter_base.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ async def continue_conversation( # pylint: disable=arguments-differ
150150
self,
151151
reference: ConversationReference,
152152
callback: Callable,
153+
bot_app_id: str,
153154
):
154155
"""
155156
Sends a proactive message to a conversation.
@@ -161,9 +162,12 @@ async def continue_conversation( # pylint: disable=arguments-differ
161162
:type reference: :class:`botbuilder.schema.ConversationReference`
162163
:param callback: The method to call for the resulting bot turn.
163164
:type callback: :class:`typing.Callable`
165+
:param bot_app_id: The application Id of the bot. This is the appId returned by the Azure portal registration,
166+
and is generally found in the `MicrosoftAppId` parameter in `config.py`.
167+
:type bot_app_id: :class:`typing.str`
164168
"""
165169
return await self.process_proactive(
166-
self.create_claims_identity(),
170+
self.create_claims_identity(bot_app_id),
167171
get_continuation_activity(reference),
168172
None,
169173
callback,
@@ -182,7 +186,7 @@ async def continue_conversation_with_claims(
182186

183187
async def create_conversation( # pylint: disable=arguments-differ
184188
self,
185-
bot_app_id: ConversationReference,
189+
bot_app_id: str,
186190
callback: Callable[[TurnContext], Awaitable] = None,
187191
conversation_parameters: ConversationParameters = None,
188192
channel_id: str = None,
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
msrest==0.6.*
1+
msrest== 0.7.*
22
botframework-connector==4.15.0
33
botbuilder-schema==4.15.0
44
botframework-streaming==4.15.0
55
requests==2.31.0
66
PyJWT==2.4.0
7-
cryptography==41.0.4
7+
cryptography==41.0.6
88
aiounittest==1.3.0
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
msrest==0.6.*
1+
msrest== 0.7.*
22
botframework-connector==4.15.0
33
botbuilder-schema==4.15.0
44
botbuilder-core==4.15.0
55
requests==2.31.0
66
PyJWT==2.4.0
7-
cryptography==41.0.4
7+
cryptography==41.0.6
88
aiounittest==1.3.0

libraries/botbuilder-dialogs/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from setuptools import setup
66

77
REQUIRES = [
8-
"regex<=2019.08.19",
8+
"regex>=2022.1.18",
99
"emoji==1.7.0",
1010
"recognizers-text-date-time>=1.0.2a1",
1111
"recognizers-text-number-with-unit>=1.0.2a1",
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
msrest==0.6.*
1+
msrest== 0.7.*
22
botframework-connector==4.15.0
33
botbuilder-schema==4.15.0
4-
aiohttp==3.8.5
4+
aiohttp==3.9.0
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
aiounittest==1.3.0
2-
msrest==0.6.*
2+
msrest== 0.7.*

libraries/botbuilder-schema/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
NAME = "botbuilder-schema"
88
VERSION = os.environ["packageVersion"] if "packageVersion" in os.environ else "4.15.0"
9-
REQUIRES = ["msrest==0.6.*", "urllib3<2.0.0"]
9+
REQUIRES = ["msrest== 0.7.*", "urllib3<2.0.0"]
1010

1111
root = os.path.abspath(os.path.dirname(__file__))
1212

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
msrest==0.6.*
1+
msrest==0.7.*
22
botbuilder-schema==4.15.0
33
requests==2.31.0
44
PyJWT==2.4.0
5-
cryptography==41.0.4
5+
cryptography==41.0.6
66
msal==1.*

libraries/botframework-connector/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
NAME = "botframework-connector"
88
VERSION = os.environ["packageVersion"] if "packageVersion" in os.environ else "4.15.0"
99
REQUIRES = [
10-
"msrest==0.6.*",
10+
"msrest==0.7.*",
1111
# "requests>=2.23.0,<2.26",
1212
"PyJWT>=2.4.0",
1313
"botbuilder-schema==4.15.0",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
msrest==0.6.*
1+
msrest==0.7.*
22
botframework-connector>=4.15.0
33
botbuilder-schema>=4.15.0

pipelines/botbuilder-python-ci.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ variables:
66
COVERALLS_GIT_COMMIT: $(Build.SourceVersion)
77
COVERALLS_SERVICE_JOB_ID: $(Build.BuildId)
88
COVERALLS_SERVICE_NAME: python-ci
9-
python.37: 3.7.x
10-
python.38: 3.8.x
9+
python.37: 3.7
10+
python.38: 3.8
1111
# python.311: 3.11.x
1212
# PythonCoverallsToken: get this from Azure
1313

@@ -60,6 +60,12 @@ jobs:
6060
pip install black==22.3.0
6161
displayName: 'Install dependencies'
6262
63+
- script: 'black --check libraries'
64+
displayName: 'Check Black compliant'
65+
66+
- script: 'pylint --rcfile=.pylintrc libraries'
67+
displayName: Pylint
68+
6369
- script: |
6470
pip install pytest
6571
pip install pytest-cov
@@ -80,12 +86,6 @@ jobs:
8086
testResultsFiles: '**/test-results.$(PYTHON_VERSION).xml'
8187
testRunTitle: 'Python $(PYTHON_VERSION)'
8288

83-
- script: 'black --check libraries'
84-
displayName: 'Check Black compliant'
85-
86-
- script: 'pylint --rcfile=.pylintrc libraries'
87-
displayName: Pylint
88-
8989
- script: 'COVERALLS_REPO_TOKEN=$(PythonCoverallsToken) coveralls'
9090
displayName: 'Push test results to coveralls https://coveralls.io/github/microsoft/botbuilder-python'
9191
continueOnError: true

0 commit comments

Comments
 (0)