Skip to content

String methods should have this parameters in lib.d.ts #9654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sandersn opened this issue Jul 12, 2016 · 0 comments
Open

String methods should have this parameters in lib.d.ts #9654

sandersn opened this issue Jul 12, 2016 · 0 comments
Labels
Help Wanted You can do this Suggestion An idea for TypeScript
Milestone
Backlog

Comments

@sandersn
Copy link
Member 

// @noImplicitThis: true
String.prototype.indexOf = function(substr, start) {
    this./**/
}

Expected: Method suggestions. No error.
Actual: Nothing. this: any error.

Other types in lib.d.ts should probably also have this added too.
@mhegazy mhegazy added Suggestion An idea for TypeScript Help Wanted You can do this labels Jul 12, 2016
@sandersn sandersn mentioned this issue Jul 13, 2016
Closed
@mhegazy mhegazy added this to the Community milestone Jan 4, 2018
@RyanCavanaugh RyanCavanaugh modified the milestones: Community, Backlog Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@sandersn @RyanCavanaugh @mhegazy