Skip to content

Bug: Incorrect return type of SubtleCrypto.digest #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
btesser opened this issue Jul 22, 2015 · 2 comments
Closed

Bug: Incorrect return type of SubtleCrypto.digest #3984

btesser opened this issue Jul 22, 2015 · 2 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 2.0

Comments

@btesser
Copy link

btesser commented Jul 22, 2015

Currently window.crypto.subtle.digest() return type is specified as any. Instead, it should be a Promise<ArrayBuffer>
@RyanCavanaugh RyanCavanaugh added the Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript label Jul 22, 2015
@mhegazy mhegazy added the Bug A bug in TypeScript label Jul 22, 2015
@mhegazy mhegazy added this to the TypeScript 1.7 milestone Jul 22, 2015
@mhegazy mhegazy added the Revisit An issue worth coming back to label Jul 22, 2015
@mhegazy mhegazy self-assigned this Jul 22, 2015
@mhegazy mhegazy modified the milestones: TypeScript 2.0, TypeScript 1.7 Oct 6, 2015
@mhegazy mhegazy assigned zhengbli and unassigned mhegazy Oct 6, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Dec 8, 2015

PRs are welcomed. here is some documentation for adding new types to lib.d.ts: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes

@mhegazy mhegazy removed the Revisit An issue worth coming back to label Dec 8, 2015
@mhegazy mhegazy modified the milestones: Community, TypeScript 1.8 Dec 8, 2015
@mhegazy mhegazy added the Help Wanted You can do this label Dec 8, 2015
@rapropos rapropos mentioned this issue Jan 30, 2016
Merged
@zhengbli
Copy link
Contributor

zhengbli commented May 17, 2016 •
edited
Loading

It should be solved by microsoft/TypeScript-DOM-lib-generator#60.

@mhegazy mhegazy modified the milestones: TypeScript 2.0, Community May 17, 2016
@zhengbli zhengbli mentioned this issue Jun 17, 2016
Merged
@zhengbli zhengbli added Fixed A PR has been merged for this issue and removed Fixed in TSJS repo labels Jun 17, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.0
Development

No branches or pull requests
4 participants
@btesser @zhengbli @RyanCavanaugh @mhegazy