Skip to content

Tests don't always produce a .deleted file #35809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielRosenwasser opened this issue Dec 20, 2019 · 1 comment
Closed

Tests don't always produce a .deleted file #35809

DanielRosenwasser opened this issue Dec 20, 2019 · 1 comment
Assignees
@sandersn
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Milestone
TypeScript 3.9.1

Comments

@DanielRosenwasser
Copy link
Member

Seems like the harness doesn't correctly create a .deleted file anymore, so baseline-accepts are accumulating bogus files.
@DanielRosenwasser DanielRosenwasser added the Infrastructure Issue relates to TypeScript team infrastructure label Dec 20, 2019
@DanielRosenwasser DanielRosenwasser mentioned this issue Dec 20, 2019
Merged
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.9.1 milestone Feb 19, 2020
@sandersn
Copy link
Member

This doesn't repro, even for multi-target tests like in #34903.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandersn sandersn

Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Milestone
TypeScript 3.9.1
Development

No branches or pull requests
2 participants
@sandersn @DanielRosenwasser