Skip to content

Migration refactorings after renaming from .js to .ts files #24713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DanielRosenwasser opened this issue Jun 6, 2018 · 0 comments
Open

Migration refactorings after renaming from .js to .ts files #24713

DanielRosenwasser opened this issue Jun 6, 2018 · 0 comments
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Refactorings e.g. extract to constant or function, rename symbol Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. Suggestion An idea for TypeScript

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jun 6, 2018 •
edited
Loading

At least week's design meeting, @sheetalkamat had the idea that we should consider applying refactorings for when you rename a .js file to a .ts file.

I think this is definitely worth experimenting with. From the refactoring pipeline, I could imagine things like

  • moving from CommonJS to ES Modules
  • lifting JSDoc annotations
  • moving to classes
  • inferring from usages

Then there's project configuration. I could see

  • Generating a tsconfig.json
  • Installing @types dependencies for packages that need them.

@mjbvz @amcasey
@DanielRosenwasser DanielRosenwasser changed the title Apply migration refactorings after renaming from .js to .ts files Migration refactorings after renaming from .js to .ts files Jun 6, 2018
@DanielRosenwasser DanielRosenwasser mentioned this issue Jun 6, 2018
Open
@mhegazy mhegazy added Suggestion An idea for TypeScript Domain: Refactorings e.g. extract to constant or function, rename symbol labels Jun 6, 2018
@weswigham weswigham added Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. In Discussion Not yet reached consensus labels Nov 6, 2018
@RyanCavanaugh RyanCavanaugh removed In Discussion Not yet reached consensus labels Mar 7, 2019
@DanielRosenwasser DanielRosenwasser added the Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature label Nov 1, 2019
@DanielRosenwasser DanielRosenwasser mentioned this issue Nov 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Refactorings e.g. extract to constant or function, rename symbol Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. Suggestion An idea for TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DanielRosenwasser @weswigham @RyanCavanaugh @mhegazy