Skip to content

Language service wants all files to end in *.ts or *.d.ts #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrieken opened this issue Oct 31, 2014 · 2 comments
Closed

Language service wants all files to end in *.ts or *.d.ts #1015

jrieken opened this issue Oct 31, 2014 · 2 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@jrieken
Copy link
Member

jrieken commented Oct 31, 2014

I have noticed that bad things happen when the language service host provides a list of file names that don't end in *.ts nor *.d.ts. I strongly opt for relaxing this because often buffers are not saved yet (no filename, just some tmp-path) and will not be saved (like the playground editor)

@jrieken jrieken added this to the TypeScript 1.3 milestone Oct 31, 2014
@mhegazy mhegazy added the Bug A bug in TypeScript label Oct 31, 2014
@mhegazy mhegazy removed this from the TypeScript 1.3 milestone Oct 31, 2014
@sophiajt sophiajt added this to the TypeScript 1.4 milestone Nov 3, 2014
@mhegazy mhegazy assigned sheetalkamat and unassigned yuit Nov 7, 2014
@mhegazy mhegazy assigned mhegazy and unassigned sheetalkamat Nov 20, 2014
@mhegazy
Copy link
Contributor

mhegazy commented Nov 20, 2014

should be handled by PR #987

@mhegazy
Copy link
Contributor

mhegazy commented Dec 2, 2014

@jrieken can you give it a try and let us know how it fares.

@mhegazy mhegazy closed this as completed Dec 2, 2014
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

5 participants