Keep showing error when property doesn't exist on type

Author: okmttdhr

src/compiler/checker.ts

@@ -12703,6 +12703,7 @@ namespace ts {
                 if (accessExpression && !isConstEnumObjectType(objectType)) {
                     if (isObjectLiteralType(objectType)) {
                         if (indexType.flags & (TypeFlags.StringLiteral | TypeFlags.NumberLiteral)) {
+                            diagnostics.add(createDiagnosticForNode(accessExpression, Diagnostics.Property_0_does_not_exist_on_type_1, (indexType as StringLiteralType).value, typeToString(objectType)))
                             return undefinedType;
                         }
                         else if (indexType.flags & (TypeFlags.Number | TypeFlags.String)) {

tests/baselines/reference/augmentedTypeBracketAccessIndexSignature.errors.txt

@@ -0,0 +1,19 @@
+tests/cases/conformance/types/members/augmentedTypeBracketAccessIndexSignature.ts(12,9): error TS2339: Property '0' does not exist on type '{}'.
+
+
+==== tests/cases/conformance/types/members/augmentedTypeBracketAccessIndexSignature.ts (1 errors) ====
+    interface Foo { a }
+    interface Bar { b }
+    
+    interface Object {
+        [n: number]: Foo;
+    }
+    
+    interface Function {
+        [n: number]: Bar;
+    }
+    
+    var a = {}[0]; // Should be Foo
+            ~~~~~
+!!! error TS2339: Property '0' does not exist on type '{}'.
+    var b = (() => { })[0]; // Should be Bar

tests/baselines/reference/augmentedTypeBracketAccessIndexSignature.types

@@ -22,8 +22,8 @@ var a = {}[0]; // Should be Foo
 >0 : 0
 
 var b = (() => { })[0]; // Should be Bar
->b : error
->(() => { })[0] : error
+>b : any
+>(() => { })[0] : any
 >(() => { }) : () => void
 >() => { } : () => void
 >0 : 0

tests/baselines/reference/indexedAccessWithObjectLiteral.errors.txt

@@ -0,0 +1,64 @@
+tests/cases/compiler/indexedAccessWithObjectLiteral.ts(34,10): error TS2339: Property 'z' does not exist on type '{ a: number; b: string; c: boolean; }'.
+
+
+==== tests/cases/compiler/indexedAccessWithObjectLiteral.ts (1 errors) ====
+    function foo (id: string) {
+      return {
+          a: 1,
+          b: "",
+          c: true
+      }[id]
+    }
+    
+    function bar (id: 'a' | 'b') {
+      return {
+          a: 1,
+          b: "",
+          c: false
+      }[id]
+    }
+    
+    function baz (id: '1' | '2') {
+      return {
+          1: 1,
+          2: "",
+          3: false
+      }[id]
+    }
+    
+    function qux (id: 1 | 2) {
+      return {
+          1: 1,
+          2: "",
+          3: false
+      }[id]
+    }
+    
+    function quux (id: 'a' | 'b' | 'z') {
+      return {
+             ~
+          a: 1,
+    ~~~~~~~~~~~
+          b: "",
+    ~~~~~~~~~~~~
+          c: false
+    ~~~~~~~~~~~~~~
+      }[id]
+    ~~~~~~~
+!!! error TS2339: Property 'z' does not exist on type '{ a: number; b: string; c: boolean; }'.
+    }
+    
+    function corge(id: string) {
+      return ({
+          a: 123,
+          b: ""
+      } as Record<string, number | string>)[id]
+    }
+    
+    function grault(id: string) {
+      return ({
+          a: 123,
+          b: ""
+      } as { [k: string]: string | number})[id]
+    }
+    

tests/baselines/reference/noImplicitAnyIndexing.errors.txt

@@ -1,8 +1,10 @@
 tests/cases/compiler/noImplicitAnyIndexing.ts(12,37): error TS7015: Element implicitly has an 'any' type because index expression is not of type 'number'.
+tests/cases/compiler/noImplicitAnyIndexing.ts(19,9): error TS2339: Property 'hi' does not exist on type '{}'.
+tests/cases/compiler/noImplicitAnyIndexing.ts(22,9): error TS2339: Property '10' does not exist on type '{}'.
 tests/cases/compiler/noImplicitAnyIndexing.ts(30,10): error TS7053: Element implicitly has an 'any' type because expression of type 'any' can't be used to index type '{}'.
 
 
-==== tests/cases/compiler/noImplicitAnyIndexing.ts (2 errors) ====
+==== tests/cases/compiler/noImplicitAnyIndexing.ts (4 errors) ====
     enum MyEmusEnum {
         emu
     }
@@ -24,9 +26,13 @@ tests/cases/compiler/noImplicitAnyIndexing.ts(30,10): error TS7053: Element impl
 
     // Should report an implicit 'any'.
     var x = {}["hi"];
+            ~~~~~~~~
+!!! error TS2339: Property 'hi' does not exist on type '{}'.
 
     // Should report an implicit 'any'.
     var y = {}[10];
+            ~~~~~~
+!!! error TS2339: Property '10' does not exist on type '{}'.
 
 
     var hi: any = "hi";

tests/baselines/reference/noImplicitAnyIndexingSuppressed.errors.txt

@@ -0,0 +1,56 @@
+tests/cases/compiler/noImplicitAnyIndexingSuppressed.ts(19,9): error TS2339: Property 'hi' does not exist on type '{}'.
+tests/cases/compiler/noImplicitAnyIndexingSuppressed.ts(22,9): error TS2339: Property '10' does not exist on type '{}'.
+
+
+==== tests/cases/compiler/noImplicitAnyIndexingSuppressed.ts (2 errors) ====
+    enum MyEmusEnum {
+        emu
+    }
+    
+    // Should be okay; should be a string.
+    var strRepresentation1 = MyEmusEnum[0]
+    
+    // Should be okay; should be a string.
+    var strRepresentation2 = MyEmusEnum[MyEmusEnum.emu]
+    
+    // Should be okay, as we suppress implicit 'any' property access checks
+    var strRepresentation3 = MyEmusEnum["monehh"];
+    
+    // Should be okay; should be a MyEmusEnum
+    var strRepresentation4 = MyEmusEnum["emu"];
+    
+    
+    // Should be okay, as we suppress implicit 'any' property access checks
+    var x = {}["hi"];
+            ~~~~~~~~
+!!! error TS2339: Property 'hi' does not exist on type '{}'.
+    
+    // Should be okay, as we suppress implicit 'any' property access checks
+    var y = {}[10];
+            ~~~~~~
+!!! error TS2339: Property '10' does not exist on type '{}'.
+    
+    var hi: any = "hi";
+    
+    var emptyObj = {};
+    
+    // Should be okay, as we suppress implicit 'any' property access checks
+    var z1 = emptyObj[hi];
+    var z2 = (<any>emptyObj)[hi];
+    
+    interface MyMap<T> {
+        [key: string]: T;
+    }
+    
+    var m: MyMap<number> = {
+        "0": 0,
+        "1": 1,
+        "2": 2,
+        "Okay that's enough for today.": NaN
+    };
+    
+    var mResult1 = m[MyEmusEnum.emu];
+    var mResult2 = m[MyEmusEnum[MyEmusEnum.emu]];
+    var mResult3 = m[hi];
+    
+    

tests/baselines/reference/noImplicitAnyIndexingSuppressed.types

@@ -24,8 +24,8 @@ var strRepresentation2 = MyEmusEnum[MyEmusEnum.emu]
 
 // Should be okay, as we suppress implicit 'any' property access checks
 var strRepresentation3 = MyEmusEnum["monehh"];
->strRepresentation3 : error
->MyEmusEnum["monehh"] : error
+>strRepresentation3 : any
+>MyEmusEnum["monehh"] : any
 >MyEmusEnum : typeof MyEmusEnum
 >"monehh" : "monehh"
 
@@ -61,8 +61,8 @@ var emptyObj = {};
 
 // Should be okay, as we suppress implicit 'any' property access checks
 var z1 = emptyObj[hi];
->z1 : error
->emptyObj[hi] : error
+>z1 : any
+>emptyObj[hi] : any
 >emptyObj : {}
 >hi : any
 

tests/baselines/reference/noImplicitAnyStringIndexerOnObject.errors.txt

@@ -1,3 +1,4 @@
+tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(1,9): error TS2339: Property 'hello' does not exist on type '{}'.
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(7,1): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: string) => string; }' has no index signature. Did you mean to call 'c.get'?
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(8,13): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: string) => string; }' has no index signature. Did you mean to call 'c.get'?
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(13,13): error TS7053: Element implicitly has an 'any' type because expression of type '"hello"' can't be used to index type '{ set: (key: string) => string; }'.
@@ -14,9 +15,11 @@ tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(42,3): error TS7052:
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(43,3): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: "hello" | "world") => string; set: (key: "hello" | "world", value: string) => string; }' has no index signature. Did you mean to call 'e.set'?
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(44,3): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: "hello" | "world") => string; set: (key: "hello" | "world", value: string) => string; }' has no index signature. Did you mean to call 'e.set'?
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(45,3): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: "hello" | "world") => string; set: (key: "hello" | "world", value: string) => string; }' has no index signature. Did you mean to call 'e.set'?
+tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(49,3): error TS2339: Property 'hello' does not exist on type '{ get: (key: string) => string; set: (key: string, value: string) => void; }'.
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(50,3): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: string) => string; set: (key: string, value: string) => void; }' has no index signature. Did you mean to call 'set'?
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(51,3): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: string) => string; set: (key: string, value: string) => void; }' has no index signature. Did you mean to call 'set'?
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(52,3): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: string) => string; set: (key: string, value: string) => void; }' has no index signature. Did you mean to call 'set'?
+tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(56,3): error TS2339: Property 'hello' does not exist on type '{ get: (key: string) => string; set: (key: string, value: string) => void; }'.
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(57,3): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: string) => string; set: (key: string, value: string) => void; }' has no index signature. Did you mean to call 'set'?
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(58,3): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: string) => string; set: (key: string, value: string) => void; }' has no index signature. Did you mean to call 'set'?
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(59,3): error TS7052: Element implicitly has an 'any' type because type '{ get: (key: string) => string; set: (key: string, value: string) => void; }' has no index signature. Did you mean to call 'set'?
@@ -33,8 +36,10 @@ tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(81,1): error TS7053:
 tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(93,5): error TS2538: Type 'Dog' cannot be used as an index type.
 
 
-==== tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts (27 errors) ====
+==== tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts (30 errors) ====
     var a = {}["hello"];
+            ~~~~~~~~~~~
+!!! error TS2339: Property 'hello' does not exist on type '{}'.
     var b: string = { '': 'foo' }[''];
 
     var c = {
@@ -114,6 +119,8 @@ tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(93,5): error TS2538:
 
     {
       ({ get: (key: string) => 'hello', set: (key: string, value: string) => {} })['hello'];
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2339: Property 'hello' does not exist on type '{ get: (key: string) => string; set: (key: string, value: string) => void; }'.
       ({ get: (key: string) => 'hello', set: (key: string, value: string) => {} })['hello'] = 'modified';
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS7052: Element implicitly has an 'any' type because type '{ get: (key: string) => string; set: (key: string, value: string) => void; }' has no index signature. Did you mean to call 'set'?
@@ -127,6 +134,8 @@ tests/cases/compiler/noImplicitAnyStringIndexerOnObject.ts(93,5): error TS2538:
 
     {
       ({ foo: { get: (key: string) => 'hello', set: (key: string, value: string) => {} } }).foo['hello'];
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2339: Property 'hello' does not exist on type '{ get: (key: string) => string; set: (key: string, value: string) => void; }'.
       ({ foo: { get: (key: string) => 'hello', set: (key: string, value: string) => {} } }).foo['hello'] = 'modified';
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS7052: Element implicitly has an 'any' type because type '{ get: (key: string) => string; set: (key: string, value: string) => void; }' has no index signature. Did you mean to call 'set'?