Skip to content

Commit c0347b2

Browse files
committed
Make range type falsiness test more explicit
1 parent 4e3397e commit c0347b2

File tree

4 files changed

+25
-81
lines changed

4 files changed

+25
-81
lines changed
Lines changed: 6 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,17 @@
11
//// [rangeTypeFalsiness.ts]
2-
function a(arg: (> 0)) {
3-
if(!arg) {
4-
return false;
5-
}
6-
else {
7-
return true;
8-
}
2+
function a(arg: (> 0)): true {
3+
return !!arg;
94
}
105

11-
function b(arg: (>= 0)) {
12-
if (!arg) {
13-
return false;
14-
}
15-
else {
16-
return true;
17-
}
6+
function b(arg: (>= 0)): boolean {
7+
return !!arg;
188
}
199

2010

2111
//// [rangeTypeFalsiness.js]
2212
function a(arg) {
23-
if (!arg) {
24-
return false;
25-
}
26-
else {
27-
return true;
28-
}
13+
return !!arg;
2914
}
3015
function b(arg) {
31-
if (!arg) {
32-
return false;
33-
}
34-
else {
35-
return true;
36-
}
16+
return !!arg;
3717
}
Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,17 @@
11
=== tests/cases/compiler/rangeTypeFalsiness.ts ===
2-
function a(arg: (> 0)) {
2+
function a(arg: (> 0)): true {
33
>a : Symbol(a, Decl(rangeTypeFalsiness.ts, 0, 0))
44
>arg : Symbol(arg, Decl(rangeTypeFalsiness.ts, 0, 11))
55

6-
if(!arg) {
6+
return !!arg;
77
>arg : Symbol(arg, Decl(rangeTypeFalsiness.ts, 0, 11))
8-
9-
return false;
10-
}
11-
else {
12-
return true;
13-
}
148
}
159

16-
function b(arg: (>= 0)) {
17-
>b : Symbol(b, Decl(rangeTypeFalsiness.ts, 7, 1))
18-
>arg : Symbol(arg, Decl(rangeTypeFalsiness.ts, 9, 11))
19-
20-
if (!arg) {
21-
>arg : Symbol(arg, Decl(rangeTypeFalsiness.ts, 9, 11))
10+
function b(arg: (>= 0)): boolean {
11+
>b : Symbol(b, Decl(rangeTypeFalsiness.ts, 2, 1))
12+
>arg : Symbol(arg, Decl(rangeTypeFalsiness.ts, 4, 11))
2213

23-
return false;
24-
}
25-
else {
26-
return true;
27-
}
14+
return !!arg;
15+
>arg : Symbol(arg, Decl(rangeTypeFalsiness.ts, 4, 11))
2816
}
2917

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,22 @@
11
=== tests/cases/compiler/rangeTypeFalsiness.ts ===
2-
function a(arg: (> 0)) {
3-
>a : (arg: (> 0)) => boolean
2+
function a(arg: (> 0)): true {
3+
>a : (arg: (> 0)) => true
44
>arg : (> 0)
5+
>true : true
56

6-
if(!arg) {
7+
return !!arg;
8+
>!!arg : true
79
>!arg : false
810
>arg : (> 0)
9-
10-
return false;
11-
>false : false
12-
}
13-
else {
14-
return true;
15-
>true : true
16-
}
1711
}
1812

19-
function b(arg: (>= 0)) {
13+
function b(arg: (>= 0)): boolean {
2014
>b : (arg: (>= 0)) => boolean
2115
>arg : (>= 0)
2216

23-
if (!arg) {
17+
return !!arg;
18+
>!!arg : boolean
2419
>!arg : boolean
2520
>arg : (>= 0)
26-
27-
return false;
28-
>false : false
29-
}
30-
else {
31-
return true;
32-
>true : true
33-
}
3421
}
3522

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,9 @@
1-
// @allowUnreachableCode: false
21
// @strictNullChecks: true
32

4-
function a(arg: (> 0)) {
5-
if(!arg) {
6-
return false;
7-
}
8-
else {
9-
return true;
10-
}
3+
function a(arg: (> 0)): true {
4+
return !!arg;
115
}
126

13-
function b(arg: (>= 0)) {
14-
if (!arg) {
15-
return false;
16-
}
17-
else {
18-
return true;
19-
}
7+
function b(arg: (>= 0)): boolean {
8+
return !!arg;
209
}

0 commit comments

Comments
 (0)