Skip to content

Commit 8e75382

Browse files
ahejlsbergahejlsberg
committed
Add regression test
1 parent 5b24ea8 commit 8e75382

4 files changed

+103
-2
lines changed

‎tests/baselines/reference/conditionalTypeRelaxingConstraintAssignability.js

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,21 @@ export class Elem<
2121
new Elem(undefined as ElChildren.Void);
2222
new Elem('' as ElChildren.Text);
2323
new Elem('' as ElChildren.Void | ElChildren.Text); // error
24-
new Elem('' as ElChildren); // error
24+
new Elem('' as ElChildren); // error
25+
26+
// Repro from #31766
27+
28+
interface I { a: string }
29+
30+
type DeepPartial<T> =
31+
T extends object ? {[K in keyof T]?: DeepPartial<T[K]>} : T;
32+
33+
declare function f<T>(t: T, partial: DeepPartial<T>): T;
34+
35+
function g(p1: I, p2: Partial<I>): I {
36+
return f(p1, p2);
37+
}
38+
2539

2640
//// [conditionalTypeRelaxingConstraintAssignability.js]
2741
"use strict";
@@ -37,3 +51,6 @@ new Elem(undefined);
3751
new Elem('');
3852
new Elem(''); // error
3953
new Elem(''); // error
54+
function g(p1, p2) {
55+
return f(p1, p2);
56+
}

‎tests/baselines/reference/conditionalTypeRelaxingConstraintAssignability.symbols

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,3 +71,47 @@ new Elem('' as ElChildren); // error
7171
>Elem : Symbol(Elem, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 8, 83))
7272
>ElChildren : Symbol(ElChildren, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 0, 0), Decl(conditionalTypeRelaxingConstraintAssignability.ts, 2, 20))
7373

74+
// Repro from #31766
75+
76+
interface I { a: string }
77+
>I : Symbol(I, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 22, 27))
78+
>a : Symbol(I.a, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 26, 13))
79+
80+
type DeepPartial<T> =
81+
>DeepPartial : Symbol(DeepPartial, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 26, 25))
82+
>T : Symbol(T, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 28, 17))
83+
84+
T extends object ? {[K in keyof T]?: DeepPartial<T[K]>} : T;
85+
>T : Symbol(T, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 28, 17))
86+
>K : Symbol(K, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 29, 25))
87+
>T : Symbol(T, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 28, 17))
88+
>DeepPartial : Symbol(DeepPartial, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 26, 25))
89+
>T : Symbol(T, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 28, 17))
90+
>K : Symbol(K, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 29, 25))
91+
>T : Symbol(T, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 28, 17))
92+
93+
declare function f<T>(t: T, partial: DeepPartial<T>): T;
94+
>f : Symbol(f, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 29, 64))
95+
>T : Symbol(T, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 31, 19))
96+
>t : Symbol(t, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 31, 22))
97+
>T : Symbol(T, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 31, 19))
98+
>partial : Symbol(partial, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 31, 27))
99+
>DeepPartial : Symbol(DeepPartial, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 26, 25))
100+
>T : Symbol(T, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 31, 19))
101+
>T : Symbol(T, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 31, 19))
102+
103+
function g(p1: I, p2: Partial<I>): I {
104+
>g : Symbol(g, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 31, 56))
105+
>p1 : Symbol(p1, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 33, 11))
106+
>I : Symbol(I, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 22, 27))
107+
>p2 : Symbol(p2, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 33, 17))
108+
>Partial : Symbol(Partial, Decl(lib.es5.d.ts, --, --))
109+
>I : Symbol(I, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 22, 27))
110+
>I : Symbol(I, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 22, 27))
111+
112+
return f(p1, p2);
113+
>f : Symbol(f, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 29, 64))
114+
>p1 : Symbol(p1, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 33, 11))
115+
>p2 : Symbol(p2, Decl(conditionalTypeRelaxingConstraintAssignability.ts, 33, 17))
116+
}
117+

‎tests/baselines/reference/conditionalTypeRelaxingConstraintAssignability.types

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,3 +62,30 @@ new Elem('' as ElChildren); // error
6262
>'' as ElChildren : ElChildren
6363
>'' : ""
6464

65+
// Repro from #31766
66+
67+
interface I { a: string }
68+
>a : string
69+
70+
type DeepPartial<T> =
71+
>DeepPartial : DeepPartial<T>
72+
73+
T extends object ? {[K in keyof T]?: DeepPartial<T[K]>} : T;
74+
75+
declare function f<T>(t: T, partial: DeepPartial<T>): T;
76+
>f : <T>(t: T, partial: DeepPartial<T>) => T
77+
>t : T
78+
>partial : DeepPartial<T>
79+
80+
function g(p1: I, p2: Partial<I>): I {
81+
>g : (p1: I, p2: Partial<I>) => I
82+
>p1 : I
83+
>p2 : Partial<I>
84+
85+
return f(p1, p2);
86+
>f(p1, p2) : I
87+
>f : <T>(t: T, partial: DeepPartial<T>) => T
88+
>p1 : I
89+
>p2 : Partial<I>
90+
}
91+

‎tests/cases/compiler/conditionalTypeRelaxingConstraintAssignability.ts

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,17 @@ export class Elem<
2121
new Elem(undefined as ElChildren.Void);
2222
new Elem('' as ElChildren.Text);
2323
new Elem('' as ElChildren.Void | ElChildren.Text); // error
24-
new Elem('' as ElChildren); // error
24+
new Elem('' as ElChildren); // error
25+
26+
// Repro from #31766
27+
28+
interface I { a: string }
29+
30+
type DeepPartial<T> =
31+
T extends object ? {[K in keyof T]?: DeepPartial<T[K]>} : T;
32+
33+
declare function f<T>(t: T, partial: DeepPartial<T>): T;
34+
35+
function g(p1: I, p2: Partial<I>): I {
36+
return f(p1, p2);
37+
}

0 commit comments

Comments
 (0)