Skip to content

Commit 5de3756

Browse files
weswighamweswigham
committed
Change default maxa truncation length to 240
1 parent 0b6ca06 commit 5de3756

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

‎src/compiler/checker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2994,7 +2994,7 @@ namespace ts {
29942994

29952995
function typeToString(type: Type, enclosingDeclaration?: Node, flags: TypeFormatFlags = TypeFormatFlags.AllowUniqueESSymbolType | TypeFormatFlags.UseAliasDefinedOutsideCurrentScope, writer: EmitTextWriter = createTextWriter("")): string {
29962996
if (writer.maximumApproximateLength === undefined) {
2997-
writer.maximumApproximateLength = 100;
2997+
writer.maximumApproximateLength = defaultMaximumTruncationLength;
29982998
}
29992999
const noTruncation = compilerOptions.noErrorTruncation || flags & TypeFormatFlags.NoTruncation;
30003000
const typeNode = nodeBuilder.typeToTypeNode(type, enclosingDeclaration, toNodeBuilderFlags(flags) | NodeBuilderFlags.IgnoreErrors | (noTruncation ? NodeBuilderFlags.NoTruncation : 0), writer);

‎src/compiler/utilities.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ namespace ts {
2121

2222
export const externalHelpersModuleNameText = "tslib";
2323

24+
export const defaultMaximumTruncationLength = 240;
25+
2426
export function getDeclarationOfKind<T extends Declaration>(symbol: Symbol, kind: T["kind"]): T | undefined {
2527
const declarations = symbol.declarations;
2628
if (declarations) {

‎src/services/utilities.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1435,7 +1435,7 @@ namespace ts {
14351435

14361436
const displayPartWriter = getDisplayPartWriter();
14371437
function getDisplayPartWriter(): DisplayPartsSymbolWriter {
1438-
const maximumApproximateLength = 2000;
1438+
const maximumApproximateLength = defaultMaximumTruncationLength;
14391439
let displayParts: SymbolDisplayPart[];
14401440
let lineStart: boolean;
14411441
let indent: number;

‎tests/cases/fourslash/quickInfoCanBeTruncated.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -510,11 +510,11 @@
510510
//// f("_499", /*3*/);
511511

512512
goTo.marker("1");
513-
verify.quickInfoIs(`type A = "_0" | "_1" | "_2" | "_3" | "_4" | "_5" | "_6" | "_7" | "_8" | "_9" | "_10" | "_11" | "_12" | "_13" | "_14" | "_15" | "_16" | "_17" | "_18" | "_19" | "_20" | "_21" | "_22" | "_23" | "_24" | "_25" | "_26" | "_27" | "_28" | "_29" | "_30" | "_31" | "_32" | "_33" | "_34" | "_35" | "_36" | "_37" | "_38" | "_39" | "_40" | "_41" | "_42" | "_43" | "_44" | "_45" | "_46" | "_47" | "_48" | "_49" | "_50" | "_51" | "_52" | "_53" | "_54" | "_55" | "_56" | "_57" | "_58" | "_59" | "_60" | "_61" | "_62" | "_63" | "_64" | "_65" | "_66" | "_67" | "_68" | "_69" | "_70" | "_71" | "_72" | "_73" | "_74" | "_75" | "_76" | "_77" | "_78" | "_79" | "_80" | "_81" | "_82" | "_83" | "_84" | "_85" | "_86" | "_87" | "_88" | "_89" | "_90" | "_91" | "_92" | "_93" | "_94" | "_95" | "_96" | "_97" | "_98" | "_99" | "_100" | "_101" | "_102" | "_103" | "_104" | "_105" | "_106" | "_107" | "_108" | "_109" | "_110" | "_111" | "_112" | "_113" | "_114" | "_115" | "_116" | "_117" | "_118" | "_119" | "_120" | "_121" | "_122" | "_123" | "_124" | "_125" | "_126" | "_127" | "_128" | "_129" | "_130" | "_131" | "_132" | "_133" | "_134" | "_135" | "_136" | "_137" | "_138" | "_139" | "_140" | "_141" | "_142" | "_143" | "_144" | "_145" | "_146" | "_147" | "_148" | "_149" | "_150" | "_151" | "_152" | "_153" | "_154" | "_155" | "_156" | "_157" | "_158" | "_159" | "_160" | "_161" | "_162" | "_163" | "_164" | "_165" | "_166" | "_167" | "_168" | "_169" | "_170" | "_171" | "_172" | "_173" | "_174" | "_175" | "_176" | "_177" | "_178" | "_179" | "_180" | "_181" | "_182" | "_183" | "_184" | "_185" | "_186" | "_187" | "_188" | "_189" | "_190" | "_191" | "_192" | "_193" | "_194" | "_195" | "_196" | "_197" | "_198" | "_199" | "_200" | "_201" | "_202" | "_203" | "_204" | "_205" | "_206" | "_207" | "_208" | "_209" | "_210" | "_211" | "_212" | "_213" | "_214" | "_215" | "_216" | "_217" | "_218" | "_219" | "_220" | "_221" | "_222" | "_223" | "_224" | "_225" | "_226" | "_227" | "_228" | "_229" | "_230" | "_231" | "_232" | "_233" | "_234" ...`);
513+
verify.quickInfoIs(`type A = "_0" | "_1" | "_2" | "_3" | "_4" | "_5" | "_6" | "_7" | "_8" | "_9" | "_10" | "_11" | "_12" | "_13" | "_14" | "_15" | "_16" | "_17" | "_18" | "_19" | "_20" | "_21" | "_22" | "_23" | "_24" | "_25" | "_26" | "_27" | "_28" | "_29" | "_30" | "_31" ...`);
514514
goTo.marker("2");
515-
verify.quickInfoIs(`type Less = "_1" | "_2" | "_3" | "_4" | "_5" | "_6" | "_7" | "_8" | "_9" | "_10" | "_11" | "_12" | "_13" | "_14" | "_15" | "_16" | "_17" | "_18" | "_19" | "_20" | "_21" | "_22" | "_23" | "_24" | "_25" | "_26" | "_27" | "_28" | "_29" | "_30" | "_31" | "_32" | "_33" | "_34" | "_35" | "_36" | "_37" | "_38" | "_39" | "_40" | "_41" | "_42" | "_43" | "_44" | "_45" | "_46" | "_47" | "_48" | "_49" | "_50" | "_51" | "_52" | "_53" | "_54" | "_55" | "_56" | "_57" | "_58" | "_59" | "_60" | "_61" | "_62" | "_63" | "_64" | "_65" | "_66" | "_67" | "_68" | "_69" | "_70" | "_71" | "_72" | "_73" | "_74" | "_75" | "_76" | "_77" | "_78" | "_79" | "_80" | "_81" | "_82" | "_83" | "_84" | "_85" | "_86" | "_87" | "_88" | "_89" | "_90" | "_91" | "_92" | "_93" | "_94" | "_95" | "_96" | "_97" | "_98" | "_99" | "_100" | "_101" | "_102" | "_103" | "_104" | "_105" | "_106" | "_107" | "_108" | "_109" | "_110" | "_111" | "_112" | "_113" | "_114" | "_115" | "_116" | "_117" | "_118" | "_119" | "_120" | "_121" | "_122" | "_123" | "_124" | "_125" | "_126" | "_127" | "_128" | "_129" | "_130" | "_131" | "_132" | "_133" | "_134" | "_135" | "_136" | "_137" | "_138" | "_139" | "_140" | "_141" | "_142" | "_143" | "_144" | "_145" | "_146" | "_147" | "_148" | "_149" | "_150" | "_151" | "_152" | "_153" | "_154" | "_155" | "_156" | "_157" | "_158" | "_159" | "_160" | "_161" | "_162" | "_163" | "_164" | "_165" | "_166" | "_167" | "_168" | "_169" | "_170" | "_171" | "_172" | "_173" | "_174" | "_175" | "_176" | "_177" | "_178" | "_179" | "_180" | "_181" | "_182" | "_183" | "_184" | "_185" | "_186" | "_187" | "_188" | "_189" | "_190" | "_191" | "_192" | "_193" | "_194" | "_195" | "_196" | "_197" | "_198" | "_199" | "_200" | "_201" | "_202" | "_203" | "_204" | "_205" | "_206" | "_207" | "_208" | "_209" | "_210" | "_211" | "_212" | "_213" | "_214" | "_215" | "_216" | "_217" | "_218" | "_219" | "_220" | "_221" | "_222" | "_223" | "_224" | "_225" | "_226" | "_227" | "_228" | "_229" | "_230" | "_231" | "_232" | "_233" | "_234" | "_235" ...`);
515+
verify.quickInfoIs(`type Less = "_1" | "_2" | "_3" | "_4" | "_5" | "_6" | "_7" | "_8" | "_9" | "_10" | "_11" | "_12" | "_13" | "_14" | "_15" | "_16" | "_17" | "_18" | "_19" | "_20" | "_21" | "_22" | "_23" | "_24" | "_25" | "_26" | "_27" | "_28" | "_29" | "_30" | "_31" | "_32" ...`);
516516
goTo.marker("3");
517517
verify.signatureHelp({
518518
marker: "3",
519-
text: `f<T extends "_0" | "_1" | "_2" | "_3" | "_4" | "_5" | "_6" | "_7" | "_8" | "_9" | "_10" | "_11" | "_12" | "_13" | "_14" | "_15" | "_16" | "_17" | "_18" | "_19" | "_20" | "_21" | "_22" | "_23" | "_24" | "_25" | "_26" | "_27" | "_28" | "_29" | "_30" | "_31" | "_32" | "_33" | "_34" | "_35" | "_36" | "_37" | "_38" | "_39" | "_40" | "_41" | "_42" | "_43" | "_44" | "_45" | "_46" | "_47" | "_48" | "_49" | "_50" | "_51" | "_52" | "_53" | "_54" | "_55" | "_56" | "_57" | "_58" | "_59" | "_60" | "_61" | "_62" | "_63" | "_64" | "_65" | "_66" | "_67" | "_68" | "_69" | "_70" | "_71" | "_72" | "_73" | "_74" | "_75" | "_76" | "_77" | "_78" | "_79" | "_80" | "_81" | "_82" | "_83" | "_84" | "_85" | "_86" | "_87" | "_88" | "_89" | "_90" | "_91" | "_92" | "_93" | "_94" | "_95" | "_96" | "_97" | "_98" | "_99" | "_100" | "_101" | "_102" | "_103" | "_104" | "_105" | "_106" | "_107" | "_108" | "_109" | "_110" | "_111" | "_112" | "_113" | "_114" | "_115" | "_116" | "_117" | "_118" | "_119" | "_120" | "_121" | "_122" | "_123" | "_124" | "_125" | "_126" | "_127" | "_128" | "_129" | "_130" | "_131" | "_132" | "_133" | "_134" | "_135" | "_136" | "_137" | "_138" | "_139" | "_140" | "_141" | "_142" | "_143" | "_144" | "_145" | "_146" | "_147" | "_148" | "_149" | "_150" | "_151" | "_152" | "_153" | "_154" | "_155" | "_156" | "_157" | "_158" | "_159" | "_160" | "_161" | "_162" | "_163" | "_164" | "_165" | "_166" | "_167" | "_168" | "_169" | "_170" | "_171" | "_172" | "_173" | "_174" | "_175" | "_176" | "_177" | "_178" | "_179" | "_180" | "_181" | "_182" | "_183" | "_184" | "_185" | "_186" | "_187" | "_188" | "_189" | "_190" | "_191" | "_192" | "_193" | "_194" | "_195" | "_196" | "_197" | "_198" | "_199" | "_200" | "_201" | "_202" | "_203" | "_204" | "_205" | "_206" | "_207" | "_208" | "_209" | "_210" | "_211" | "_212" | "_213" | "_214" | "_215" | "_216" | "_217" | "_218" | "_219" | "_220" | "_221" | "_222" | "_223" | "_224" | "_225" | "_226" | "_227" | "_228" | "_229" | "_230" | "_231" | "_232" | "_233" ...(s: T, x: Exclude<"_0", T> | Exclude<"_1", T> | Exclude<"_2", T> | Exclude<"_3", T> | Exclude<"_4", T> | Exclude<"_5", T> | Exclude<"_6", T> | Exclude<"_7", T> | Exclude<"_8", T> | Exclude<"_9", T> | Exclude<"_10", T> | Exclude<"_11", T> | Exclude<"_12", T> | Exclude<"_13", T> | Exclude<"_14", T> | Exclude<"_15", T> | Exclude<"_16", T> | Exclude<"_17", T> | Exclude<"_18", T> | Exclude<"_19", T> | Exclude<"_20", T> | Exclude<"_21", T> | Exclude<"_22", T> | Exclude<"_23", T> | Exclude<"_24", T> | Exclude<"_25", T> | Exclude<"_26", T> | Exclude<"_27", T> | Exclude<"_28", T> | Exclude<"_29", T> | Exclude<"_30", T> | Exclude<"_31", T> | Exclude<"_32", T> | Exclude<"_33", T> | Exclude<"_34", T> | Exclude<"_35", T> | Exclude<"_36", T> | Exclude<"_37", T> | Exclude<"_38", T> | Exclude<"_39", T> | Exclude<"_40", T> | Exclude<"_41", T> | Exclude<"_42", T> | Exclude<"_43", T> | Exclude<"_44", T> | Exclude<"_45", T> | Exclude<"_46", T> | Exclude<"_47", T> | Exclude<"_48", T> | Exclude<"_49", T> | Exclude<"_50", T> | Exclude<"_51", T> | Exclude<"_52", T> | Exclude<"_53", T> | Exclude<"_54", T> | Exclude<"_55", T> | Exclude<"_56", T> | Exclude<"_57", T> | Exclude<"_58", T> | Exclude<"_59", T> | Exclude<"_60", T> | Exclude<"_61", T> | Exclude<"_62", T> | Exclude<"_63", T> | Exclude<"_64", T> | Exclude<"_65", T> | Exclude<"_66", T> | Exclude<"_67", T> | Exclude<"_68", T> | Exclude<"_69", T> | Exclude<"_70", T> | Exclude<"_71", T> | Exclude<"_72", T> | Exclude<"_73", T> | Exclude<"_74", T> | Exclude<"_75", T> | Exclude<"_76", T> | Exclude<"_77", T> | Exclude<"_78", T> | Exclude<"_79", T> | Exclude<"_80", T> | Exclude<"_81", T> | Exclude<"_82", T> | Exclude<"_83", T> | Exclude<"_84", T> | Exclude<"_85", T> | Exclude<"_86", T> | Exclude<"_87", T> | Exclude<"_88", T> | Exclude<"_89", T> | Exclude<"_90", T> | Exclude<"_91", T> | Exclude<"_92", T> | Exclude<"_93", T> | Exclude<"_94", T> | Exclude<"_95", T> | Exclude<"_96", T> | Exclude<"_97", T> | Exclude<"_98", T> | Exclude<"_99", T> | Exclude< ..., y: string): void`
519+
text: `f<T extends "_0" | "_1" | "_2" | "_3" | "_4" | "_5" | "_6" | "_7" | "_8" | "_9" | "_10" | "_11" | "_12" | "_13" | "_14" | "_15" | "_16" | "_17" | "_18" | "_19" | "_20" | "_21" | "_22" | "_23" | "_24" | "_25" | "_26" | "_27" | "_28" | "_29" | ...(s: T, x: Exclude<"_0", T> | Exclude<"_1", T> | Exclude<"_2", T> | Exclude<"_3", T> | Exclude<"_4", T> | Exclude<"_5", T> | Exclude<"_6", T> | Exclude<"_7", T> | Exclude<"_8", T> | Exclude<"_9", T> | Exclude<"_10", T> | Exclude<"_11", T> | Exclude< ..., y: string): void`
520520
});

0 commit comments

Comments
 (0)