Skip to content

RtcRtpEncodingParameters.maxFramerate not included #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nainkunal933 opened this issue Aug 17, 2022 · 1 comment
Open

RtcRtpEncodingParameters.maxFramerate not included #1380

nainkunal933 opened this issue Aug 17, 2022 · 1 comment

Comments

@nainkunal933
Copy link

Hi,

As I was going through the definitions, it seems like in Typescript 4.3 or @types/[email protected] maxFramerate was not included. At the time, it looks like maxFramerate did not have enough support among multiple browsers. Since then, the browser support has increased sufficiently: https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpEncodingParameters/maxFramerate.

I went through the contribution guidelines and confirmed that maxFramerate is not included in inputfiles/removedTypes.jsonc. The exclusion of maxFramerate is a breaking change for us. There is another instance of this being a breaking change: #991 (comment) for another dev.

I will like to know if maxFramerate can be added back to the types?

@saschanaz
Copy link
Contributor

This is because people are not sure it's interop-ready: w3c/webrtc-extensions#108

That said, the implementation detail doesn't matter for TypeScript. I'll accept a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants