Skip to content

Commit 88ca7ea

Browse files
committed
Add some comments
1 parent 4d97828 commit 88ca7ea

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

TS.fsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,8 @@ module InputIdlJson =
151151
let hasType itemName =
152152
allTypedefsMap.ContainsKey itemName
153153

154+
// Converts new JSON types to existing matching XML types
155+
// to reduce code duplication before removing XML support
154156
module Compat =
155157
let xNamespace = XNamespace.Get "http://schemas.microsoft.com/ie/webidl-xml"
156158

@@ -1489,15 +1491,19 @@ module Emit =
14891491
let emitTypeDefFromJson (typeDef: InputJsonType.Root) =
14901492
Pt.Printl "type %s = %s;" typeDef.Name.Value typeDef.Type.Value
14911493

1494+
// Load typedefs from XML input
14921495
let mutable map = browser.Typedefs |> Array.map(fun i -> (i.NewType, i)) |> Map.ofArray
1496+
// Load and merge typedefs from new JSON input
14931497
InputIdlJson.inputIdl.Typedefs
14941498
|> Array.iter (InputIdlJson.Compat.convertTypedef >> (fun i -> map <- map.Add(i.NewType, i)))
1495-
1499+
1500+
// Filter by removedType.json + knownWorkerInterfaces.json
14961501
map |> Map.toArray |> Array.map snd
14971502
|> Array.filter (fun typedef -> getRemovedItemByName typedef.NewType ItemKind.TypeDef "" |> Option.isNone)
14981503
|> Array.filter (fun i -> (flavor <> Flavor.Worker || knownWorkerInterfaces.Contains i.NewType))
14991504
|> Array.iter emitTypeDef
15001505

1506+
// Load manual additions from addedType.json
15011507
InputJson.getAddedItems ItemKind.TypeDef flavor
15021508
|> Array.iter emitTypeDefFromJson
15031509

0 commit comments

Comments
 (0)