Codelyzer doesn't support export default

[wKoza]

I reedit my comment form the PR #754.

If we create a simple class like that:

export default class { ... }

and we launch ng lint, we have a big big crash [here] (https://github.com/mgechev/codelyzer/blob/master/src/propertyDecoratorBase.ts#L41) and many other places !

[mgechev]

That's probably in the Angular router where we collect the metadata?

[wKoza]

Each call to visitClassDeclaration is often following by node.name!.text, here or there and without name ... it's the crash
I'll do a complete check tomorrow.

[rafaelss95]

I agree that instead of using the non-null assertion operator, we should check all these properties correctly!

However, I disagree on the point of returning class names (not just class names) in failure messages because I don't see much value in returning them since the lint already returns the exact line where failure occurred accompanied by a (descriptive) message.

I really prefer to return generic/direct messages without polluting the output with class/variable names, as TSLint does, for example.

One example is use-pipe-transform-interface:

Current message: The CLASSNAME class has the Pipe decorator, so it should implement the PipeTransform interface
Direct message: (or something like this): Classes decorated with @Pipe decorator should implement PipeTransform interface.

I hope you got the idea.

[wKoza]

I didn't go much more deeper into the analyse. But, I can say that a class with an Angular decorator and no name should be throw an error.
@rafaelss95 , your idea is interesting. A generic message allows to make statistic easily.

[mgechev]

@rafaelss95 yes, this makes sense.