Skip to content

About rule names #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rafaelss95 opened this issue May 26, 2018 · 3 comments · Fixed by #754
Closed

About rule names #653

rafaelss95 opened this issue May 26, 2018 · 3 comments · Fixed by #754

Comments

@rafaelss95
Copy link
Collaborator

rafaelss95 commented May 26, 2018

Template rules are a little bit mixed, some start with template, others with templates, others with nothing.
I want to propose to normalize them with the prefix template-:

banana-in-box -> template-banana-in-box;
i18n -> template-i18n;
templates-no-negated-async -> template-no-negated-async
trackBy-function -> template-use-trackBy-function (not sure about the capitalized "B")
angular-whitespace -> template-whitespace


Also, another suggestions for names would be:

All the *-life-cycle-* rules should be renamed to *-lifecycle-*, as mentioned in some issues/PRs;
no-output-named-after-standard-event should be renamed to no-output-standard-event or something like that since this rule cares precisely about exact output names.

@mgechev
Copy link
Owner

mgechev commented Jun 13, 2018

@rafaelss95 the proposal makes sense. We should coordinate the effort with Angular CLI. It might be a good idea to push the changes before their next major release.

@rafaelss95
Copy link
Collaborator Author

rafaelss95 commented Feb 6, 2019

Hey @mgechev :), what about make these changes before Angular 8?

@mgechev
Copy link
Owner

mgechev commented Feb 6, 2019

@rafaelss95 yes, feel free! // cc @wKoza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants