-
Notifications
You must be signed in to change notification settings - Fork 237
About rule names #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@rafaelss95 the proposal makes sense. We should coordinate the effort with Angular CLI. It might be a good idea to push the changes before their next major release. |
Hey @mgechev :), what about make these changes before Angular 8? |
@rafaelss95 yes, feel free! // cc @wKoza |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Template rules are a little bit mixed, some start with
template
, others withtemplates
, others with nothing.I want to propose to normalize them with the prefix
template-
:banana-in-box
->template-banana-in-box
;i18n
->template-i18n
;templates-no-negated-async
->template-no-negated-async
trackBy-function
->template-use-trackBy-function
(not sure about the capitalized "B")angular-whitespace
->template-whitespace
Also, another suggestions for names would be:
All the
*-life-cycle-*
rules should be renamed to*-lifecycle-*
, as mentioned in some issues/PRs;no-output-named-after-standard-event
should be renamed tono-output-standard-event
or something like that since this rule cares precisely about exact output names.The text was updated successfully, but these errors were encountered: