raise in places that have a kwarg casting, besides np.astype

Author: mattip

TODO_same_value

@@ -1,12 +1,5 @@
-- Check where PyArray_CopyObject, PyArray_NewCopy, PyArray_CopyInto, array_datetime_as_string, PyArray_Concatenate, PyArray_where are used, do we need a 'same_value' equivalents?
-- In PyArray_FromArray(arr, newtype, flags) should there be a SAME_VALUE flag?
-- Examine places where PyArray_CastingConverter is used and add SAME_VALUE handling
-  - array_datetime_as_string:
-  - array_copyto: 
+- Finish PyArray_AssignArray
   - PyArray_AssignArray with wheremask (called with a cast arg)
   - PyArray_AssignRawScalar with/without wheremask
-  - PyArray_ConcatenateInto (called with a cast arg)
-  - PyArray_EinsteinSum (called with a cast arg)
-  - NpyIter_AdvancedNew (called with a cast arg)
 In CanCast, make sure user defined and datetime dtypes will fail with SAME_VALUE
 ----

numpy/_core/src/multiarray/array_assign_array.c

@@ -245,6 +245,12 @@ raw_array_wheremasked_assign_array(int ndim, npy_intp const *shape,
                         &cast_info, &method_flags) != NPY_SUCCEED) {
         return -1;
     }
+    if (same_value_cast) {
+        cast_info.context.flags |= NPY_SAME_VALUE_CASTING;
+        PyErr_SetString(PyExc_NotImplementedError,
+            "raw_array_wheremasked_assign_array with 'same_value' casting not implemented yet");
+        return -1;
+    }
 
     if (!(method_flags & NPY_METH_NO_FLOATINGPOINT_ERRORS)) {
         npy_clear_floatstatus_barrier(src_data);
@@ -256,9 +262,7 @@ raw_array_wheremasked_assign_array(int ndim, npy_intp const *shape,
         }
         NPY_BEGIN_THREADS_THRESHOLDED(nitems);
     }
-    if (same_value_cast) {
-        cast_info.context.flags |= NPY_SAME_VALUE_CASTING;
-    }
+
     npy_intp strides[2] = {src_strides_it[0], dst_strides_it[0]};
 
     NPY_RAW_ITER_START(idim, ndim, coord, shape_it) {

numpy/_core/src/multiarray/datetime.c

@@ -1236,7 +1236,6 @@ can_cast_datetime64_units(NPY_DATETIMEUNIT src_unit,
     switch (casting) {
         /* Allow anything with unsafe casting */
         case NPY_UNSAFE_CASTING:
-        case NPY_SAME_VALUE_CASTING:
             return 1;
 
         /*
@@ -1262,6 +1261,8 @@ can_cast_datetime64_units(NPY_DATETIMEUNIT src_unit,
                 return (src_unit <= dst_unit);
             }
 
+        case NPY_SAME_VALUE_CASTING:
+            return 0;
         /* Enforce equality with 'no' or 'equiv' casting */
         default:
             return src_unit == dst_unit;

numpy/_core/src/multiarray/einsum.c.src

@@ -830,6 +830,12 @@ PyArray_EinsteinSum(char *subscripts, npy_intp nop,
         return NULL;
     }
 
+    if (casting == NPY_SAME_VALUE_CASTING) {
+        PyErr_SetString(PyExc_NotImplementedError,
+            "einsum with casting='same_value' not implemented yet");
+        return NULL;
+    }
+
     /* Parse the subscripts string into label_counts and op_labels */
     memset(label_counts, 0, sizeof(label_counts));
     for (iop = 0; iop < nop; ++iop) {

numpy/_core/src/multiarray/multiarraymodule.c

@@ -666,6 +666,12 @@ PyArray_ConcatenateInto(PyObject *op,
                 "argument, but both were provided.");
         return NULL;
     }
+    if (casting == NPY_SAME_VALUE_CASTING) {
+        PyErr_SetString(PyExc_NotImplementedError,
+            "concatenate with casting='same_value' not implemented yet");
+        return NULL;
+    }
+
 
     /* Convert the input list into arrays */
     narrays = PySequence_Size(op);
@@ -1940,6 +1946,11 @@ array_copyto(PyObject *NPY_UNUSED(ignored),
             NULL, NULL, NULL) < 0) {
         goto fail;
     }
+    if (casting == NPY_SAME_VALUE_CASTING) {
+        PyErr_SetString(PyExc_NotImplementedError,
+            "raw_array_wheremasked_assign_array with 'same_value' casting not implemented yet");
+        goto fail;
+    }
 
     if (!PyArray_Check(dst_obj)) {
         PyErr_Format(PyExc_TypeError,

numpy/_core/src/umath/ufunc_object.c

@@ -4538,6 +4538,10 @@ ufunc_generic_fastcall(PyUFuncObject *ufunc,
             full_args.in, casting) < 0) {
         goto fail;
     }
+    if (casting == NPY_SAME_VALUE_CASTING) {
+        PyErr_SetString(PyExc_NotImplementedError,
+            "ufunc with 'same_value' casting not implemented yet");
+    }
 
     /*
      * Do the final preparations and call the inner-loop.

numpy/_core/tests/test_datetime.py

@@ -1840,6 +1840,10 @@ def test_datetime_as_string(self):
                             '2032-07-18')
         assert_equal(np.datetime_as_string(a, unit='D', casting='unsafe'),
                             '2032-07-18')
+
+        with pytest.raises(TypeError):
+            np.datetime_as_string(a, unit='Y', casting='same_value')
+
         assert_equal(np.datetime_as_string(a, unit='h'), '2032-07-18T12')
         assert_equal(np.datetime_as_string(a, unit='m'),
                             '2032-07-18T12:23')
@@ -1886,6 +1890,7 @@ def test_datetime_as_string(self):
                 np.datetime64('2032-01-01T00:00:00', 'us'), unit='auto'),
                 '2032-01-01')
 
+
     @pytest.mark.skipif(not _has_pytz, reason="The pytz module is not available.")
     def test_datetime_as_string_timezone(self):
         # timezone='local' vs 'UTC'

numpy/_core/tests/test_einsum.py

@@ -79,6 +79,11 @@ def test_einsum_errors(self, do_opt, einsum_fn):
             b = np.ones((3, 4, 5))
             einsum_fn('aabcb,abc', a, b)
 
+        with pytest.raises(NotImplementedError):
+            a = np.arange(3)
+            # einsum_path does not accept kwarg 'casting'
+            np.einsum('ij->j', [a, a], casting='same_value')
+
     def test_einsum_sorting_behavior(self):
         # Case 1: 26 dimensions (all lowercase indices)
         n1 = 26

numpy/_core/tests/test_shape_base.py

@@ -365,6 +365,11 @@ def test_concatenate(self):
         assert_(out is rout)
         assert_equal(res, rout)
 
+    def test_concatenate_same_value(self):
+        r4 = list(range(4))
+        with pytest.raises(NotImplementedError):
+            concatenate([r4, r4], casting="same_value")
+
     @pytest.mark.skipif(IS_PYPY, reason="PYPY handles sq_concat, nb_add differently than cpython")
     def test_operator_concat(self):
         import operator