Skip to content

Less compilation extend 'mixin' has no matches #23619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
patruvlad opened this issue Jul 8, 2019 · 20 comments
Closed

Less compilation extend 'mixin' has no matches #23619

patruvlad opened this issue Jul 8, 2019 · 20 comments
Assignees
Labels
Component: Setup Fixed in 2.3.x The issue has been fixed in 2.3 release line Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@patruvlad
Copy link

patruvlad commented Jul 8, 2019

Preconditions (*)

  1. Magento version 2.3.1 - 2.3.2
  2. Production mode

Steps to reproduce (*)

  1. Having nodejs v8 installed
  2. Setting up vanilla Magento installation using composer
  3. Run npm install [email protected]
  4. Run bin/magento setup:static-content:deploy -f -t Magento/luma en_US
  5. Run node_modules/.bin/lessc var/view_preprocessed/pub/static/frontend/Magento/luma/en_US/css/styles-m.less > /dev/null
  6. Notice the output (what you see is the output to stderr, since we redirected stdout to /dev/null):
extend ' .abs-modal-overlay' has no matches
extend ' .abs-add-clearfix-desktop' has no matches
extend ' .abs-blocks-2columns' has no matches
extend ' .abs-forms-general-desktop' has no matches
extend ' .abs-action-reset' has no matches
extend ' .abs-no-display-desktop' has no matches
extend ' .clearer' has no matches
extend ' .abs-clearfix' has no matches
extend ' .abs-action-print' has no matches

Expected result (*)

  1. The compiled css should not have anything like the extend 'mixin_name' has no matches

Actual result (*)

  1. Errors during less compilation
@m2-assistant
Copy link

m2-assistant bot commented Jul 8, 2019

Hi @patruvlad. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@patruvlad do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 8, 2019
@patruvlad
Copy link
Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @patruvlad. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@engcom-Bravo engcom-Bravo self-assigned this Jul 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 8, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@magento-engcom-team
Copy link
Contributor

Hi @patruvlad, here is your Magento instance.
Admin access: https://i-23619-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Bravo engcom-Bravo added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Setup labels Jul 8, 2019
@engcom-Bravo
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@engcom-Bravo engcom-Bravo added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Jul 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @engcom-Bravo, here is your Magento instance.
Admin access: https://i-23619-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Bravo
Copy link
Contributor

Hi @patruvlad thank you for your report, I'm not able to reproduce issue by steps you described on clean 2.3-develop.

@patruvlad
Copy link
Author

I modified the description with some Manual testing scenario , can this be reopened and rechecked?

@hostep hostep reopened this Jul 9, 2019
@ghost ghost unassigned engcom-Bravo Jul 9, 2019
@hostep
Copy link
Contributor

hostep commented Jul 9, 2019

Just to clarify, we've opened this issue, because it indicates that certain less code isn't following the less standard. It accidentally didn't output errors with the less compiler Magento ships with but if we want to use an alternative less compiler which is more strict, it should still work.

Here are some findings:

  • .abs-action-reset is being defined in adminhtml theme, but is used in a frontend theme, so that can never work. (problem was introduced recently in 2.3.2 by ffbf8e6da2f5#diff-3df2988da960a31971a90e02c78804b8)
  • .abs-action-print is being defined in a media query, but then used in a different media query so that might cause this problem
  • ..abs-forms-general-desktop, same thing over here, is being defined in a media query, but then used in a different one, so the definition can't be found when not in the exact same media query I assume?
  • ...

@engcom-Bravo engcom-Bravo self-assigned this Jul 10, 2019
@engcom-Bravo engcom-Bravo removed the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Jul 10, 2019
@engcom-Bravo
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@engcom-Bravo engcom-Bravo added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Jul 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @engcom-Bravo, here is your Magento instance.
Admin access: https://i-23619-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Bravo
Copy link
Contributor

@magento give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@engcom-Bravo engcom-Bravo added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Jul 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @engcom-Bravo, here is your Magento instance.
Admin access: https://i-23619-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Bravo engcom-Bravo added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jul 10, 2019
@ghost ghost unassigned engcom-Bravo Jul 10, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-18025, MC-18026 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team
Copy link
Contributor

Hi @patruvlad. Thank you for your report.
The issue has been fixed in #24001 by @hostep in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.4 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Aug 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @patruvlad. Thank you for your report.
The issue has been fixed in #24003 by @hostep in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Setup Fixed in 2.3.x The issue has been fixed in 2.3 release line Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants