ENGCOM-5985: [Customer] Rename dob to date_of_birth #911 #919

Author: lenaorobei

app/code/Magento/CustomerGraphQl/Model/Customer/ExtractCustomerData.php

@@ -101,11 +101,16 @@ public function execute(CustomerInterface $customer): array
             }
         }
         $customerData = array_merge($customerData, $customAttributes);
-        //Field is deprecated and should not be exposed on storefront.
+        //Fields are deprecated and should not be exposed on storefront.
         $customerData['group_id'] = null;
-        $customerData['model'] = $customer;
         $customerData['id'] = null;
 
+        $customerData['model'] = $customer;
+
+        //'dob' is deprecated, 'date_of_birth' is used instead.
+        if (!empty($customerData['dob'])) {
+            $customerData['date_of_birth'] = $customerData['dob'];
+        }
         return $customerData;
     }
 }

app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php

@@ -70,7 +70,9 @@ public function resolve(
         if (!$this->newsLetterConfig->isActive(ScopeInterface::SCOPE_STORE)) {
             $args['input']['is_subscribed'] = false;
         }
-      
+        if (isset($args['input']['date_of_birth'])) {
+            $args['input']['dob'] = $args['input']['date_of_birth'];
+        }
         $customer = $this->createCustomerAccount->execute(
             $args['input'],
             $context->getExtensionAttributes()->getStore()

app/code/Magento/CustomerGraphQl/Model/Resolver/UpdateCustomer.php

@@ -70,6 +70,9 @@ public function resolve(
         if (empty($args['input']) || !is_array($args['input'])) {
             throw new GraphQlInputException(__('"input" value should be specified'));
         }
+        if (isset($args['input']['date_of_birth'])) {
+            $args['input']['dob'] = $args['input']['date_of_birth'];
+        }
 
         $customer = $this->getCustomer->execute($context);
         $this->updateCustomerAccount->execute(

app/code/Magento/CustomerGraphQl/etc/schema.graphqls

@@ -61,7 +61,8 @@ input CustomerInput {
     lastname: String @doc(description: "The customer's family name")
     suffix: String @doc(description: "A value such as Sr., Jr., or III")
     email: String @doc(description: "The customer's email address. Required")
-    dob: String @doc(description: "The customer's date of birth")
+    dob: String @doc(description: "Deprecated: Use `date_of_birth` instead")
+    date_of_birth: String @doc(description: "The customer's date of birth")
     taxvat: String @doc(description: "The customer's Tax/VAT number (for corporate customers)")
     gender: Int @doc(description: "The customer's gender(Male - 1, Female - 2)")
     password: String @doc(description: "The customer's password")
@@ -87,7 +88,8 @@ type Customer @doc(description: "Customer defines the customer name and address
     email: String @doc(description: "The customer's email address. Required")
     default_billing: String @doc(description: "The ID assigned to the billing address")
     default_shipping: String @doc(description: "The ID assigned to the shipping address")
-    dob: String @doc(description: "The customer's date of birth")
+    dob: String @doc(description: "The customer's date of birth") @deprecated(reason: "Use `date_of_birth` instead")
+    date_of_birth: String @doc(description: "The customer's date of birth")
     taxvat: String @doc(description: "The customer's Tax/VAT number (for corporate customers)")
     id: Int @doc(description: "The ID assigned to the customer") @deprecated(reason: "id is not needed as part of Customer because on server side it can be identified based on customer token used for authentication. There is no need to know customer ID on the client side.")
     is_subscribed: Boolean @doc(description: "Indicates whether the customer is subscribed to the company's newsletter") @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\IsSubscribed")

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerTest.php

@@ -69,7 +69,7 @@ public function testUpdateCustomer()
             middlename: "{$newMiddlename}"
             lastname: "{$newLastname}"
             suffix: "{$newSuffix}"
-            dob: "{$newDob}"
+            date_of_birth: "{$newDob}"
             taxvat: "{$newTaxVat}"
             email: "{$newEmail}"
             password: "{$currentPassword}"
@@ -82,7 +82,7 @@ public function testUpdateCustomer()
             middlename
             lastname
             suffix
-            dob
+            date_of_birth
             taxvat
             email
             gender
@@ -102,7 +102,7 @@ public function testUpdateCustomer()
         $this->assertEquals($newMiddlename, $response['updateCustomer']['customer']['middlename']);
         $this->assertEquals($newLastname, $response['updateCustomer']['customer']['lastname']);
         $this->assertEquals($newSuffix, $response['updateCustomer']['customer']['suffix']);
-        $this->assertEquals($newDob, $response['updateCustomer']['customer']['dob']);
+        $this->assertEquals($newDob, $response['updateCustomer']['customer']['date_of_birth']);
         $this->assertEquals($newTaxVat, $response['updateCustomer']['customer']['taxvat']);
         $this->assertEquals($newEmail, $response['updateCustomer']['customer']['email']);
         $this->assertEquals($newGender, $response['updateCustomer']['customer']['gender']);