ENGCOM-3227: MAGETWO-34709 Changing empty label value for first option on dropdown filters. #120

magento-engcom-team · magento-engcom-team · commit cef5301eb0ea · 2018-10-19T09:55:17.000-05:00
- Merge Pull Request magento-engcom/import-export-improvements#120 from valentinboyanov/import-export-improvements:MAGETWO-34709-fix-select-type-filter - Merged commits: 1. e258878
diff --git a/app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php b/app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php
@@ -250,7 +250,7 @@ protected function _getSelectHtmlWithValue(Attribute $attribute, $value)
             if ('' === $firstOption['value']) {
                 $options[key($options)]['label'] = '';
             } else {
-                array_unshift($options, ['value' => '', 'label' => '']);
+                array_unshift($options, ['value' => '', 'label' => __('-- Not Selected --')]);
             }
             $arguments = [
                 'name' => $this->getFilterElementName($attribute->getAttributeCode()),

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ protected function _getSelectHtmlWithValue(Attribute $attribute, $value)`
`250`	`250`	`if ('' === $firstOption['value']) {`
`251`	`251`	`$options[key($options)]['label'] = '';`
`252`	`252`	`} else {`
`253`		`- array_unshift($options, ['value' => '', 'label' => '']);`
	`253`	`+ array_unshift($options, ['value' => '', 'label' => __('-- Not Selected --')]);`
`254`	`254`	`}`
`255`	`255`	`$arguments = [`
`256`	`256`	`'name' => $this->getFilterElementName($attribute->getAttributeCode()),`