Skip to content

Commit 566d475

Browse files
authored
Merge branch '2.4-develop' into order-cancellation
2 parents 458034b + f765139 commit 566d475

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

dev/tests/integration/testsuite/Magento/GraphQl/App/State/Collector.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function __construct(
4545
*/
4646
private function copyArray(
4747
array $array,
48-
CompareType $compareType,
48+
string $compareType,
4949
int $recursionLevel,
5050
int $arrayRecursionLevel = 100
5151
) : array {
@@ -86,7 +86,7 @@ function ($element) use (
8686
* @param ShouldResetState $shouldResetState
8787
* @return CollectedObject[]
8888
*/
89-
public function getSharedObjects(ShouldResetState $shouldResetState): array
89+
public function getSharedObjects(string $shouldResetState): array
9090
{
9191
if ($this->objectManager instanceof ObjectManager) {
9292
$sharedInstances = $this->objectManager->getSharedInstances();
@@ -156,7 +156,7 @@ public function getPropertiesConstructedAndCurrent(): array
156156
*/
157157
public function getPropertiesFromObject(
158158
object $object,
159-
CompareType $compareType,
159+
string $compareType,
160160
int $recursionLevel = 1,
161161
): CollectedObject {
162162
$className = get_class($object);

dev/tests/integration/testsuite/Magento/GraphQl/App/State/CompareType.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@
99

1010
/**
1111
* What type of comparison
12+
*
13+
* TODO: change this back into enum once magento-semvar is fixed
1214
*/
13-
enum CompareType
15+
class CompareType
1416
{
15-
case CompareBetweenRequests;
16-
case CompareConstructedAgainstCurrent;
17+
public const CompareBetweenRequests = "CompareBetweenRequests";
18+
public const CompareConstructedAgainstCurrent = "CompareConstructedAgainstCurrent";
1719
}

dev/tests/integration/testsuite/Magento/GraphQl/App/State/ShouldResetState.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@
77

88
namespace Magento\GraphQl\App\State;
99

10-
enum ShouldResetState
10+
// TODO: change this back into enum once magento-semvar is fixed
11+
class ShouldResetState
1112
{
12-
case DoResetState;
13-
case DoNotResetState;
13+
public const DoResetState = "DoResetState";
14+
public const DoNotResetState = "DoNotResetState";
1415
}

dev/tests/integration/testsuite/Magento/GraphQl/App/State/SkipListAndFilterList.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function filterProperties(array $properties, array $propertiesToFilterLis
4646
* @param CompareType $compareType
4747
* @return array
4848
*/
49-
public function getSkipList(string $operationName, CompareType $compareType): array
49+
public function getSkipList(string $operationName, string $compareType): array
5050
{
5151
if ($this->skipList === null) {
5252
$skipListList = [];

0 commit comments

Comments
 (0)