Skip to content

Commit 4383e60

Browse files
author
Tulika,Eugene(etulika)
committed
Merge pull request #162 from magento-api/RC1-bugfixes
[API+Tango] RC1 Bugfixes
2 parents 976b720 + cbaf8dc commit 4383e60

File tree

7 files changed

+13
-10
lines changed

7 files changed

+13
-10
lines changed

app/code/Magento/Checkout/view/frontend/web/template/authentication.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@
6464
id="login-password"
6565
name="password"
6666
data-bind="attr: {autocomplete: autocomplete}"
67-
data-validate="{required:true, 'validate-password':true}"/>
67+
data-validate="{required:true, 'validate-password':true}"
68+
autocomplete="off"/>
6869
</div>
6970
</div>
7071
<!-- ko foreach: getRegion('additional-login-form-fields') -->

app/code/Magento/Customer/view/frontend/templates/form/edit.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,19 @@
4242
<div class="field password current required">
4343
<label class="label" for="current-password"><span><?php /* @escapeNotVerified */ echo __('Current Password') ?></span></label>
4444
<div class="control">
45-
<input type="password" class="input-text" name="current_password" id="current-password">
45+
<input type="password" class="input-text" name="current_password" id="current-password" autocomplete="off">
4646
</div>
4747
</div>
4848
<div class="field new password required">
4949
<label class="label" for="password"><span><?php /* @escapeNotVerified */ echo __('New Password') ?></span></label>
5050
<div class="control">
51-
<input type="password" class="input-text" name="password" id="password">
51+
<input type="password" class="input-text" name="password" id="password" autocomplete="off">
5252
</div>
5353
</div>
5454
<div class="field confirm password required">
5555
<label class="label" for="password-confirmation"><span><?php /* @escapeNotVerified */ echo __('Confirm New Password') ?></span></label>
5656
<div class="control">
57-
<input type="password" class="input-text" name="password_confirmation" id="password-confirmation">
57+
<input type="password" class="input-text" name="password_confirmation" id="password-confirmation" autocomplete="off">
5858
</div>
5959
</div>
6060
</fieldset>

app/code/Magento/Customer/view/frontend/templates/form/register.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,13 +140,13 @@
140140
<div class="field password required">
141141
<label for="password" class="label"><span><?php /* @escapeNotVerified */ echo __('Password') ?></span></label>
142142
<div class="control">
143-
<input type="password" name="password" id="password" title="<?php /* @escapeNotVerified */ echo __('Password') ?>" class="input-text" data-validate="{required:true, 'validate-password':true}">
143+
<input type="password" name="password" id="password" title="<?php /* @escapeNotVerified */ echo __('Password') ?>" class="input-text" data-validate="{required:true, 'validate-password':true}" autocomplete="off">
144144
</div>
145145
</div>
146146
<div class="field confirmation required">
147147
<label for="password-confirmation" class="label"><span><?php /* @escapeNotVerified */ echo __('Confirm Password') ?></span></label>
148148
<div class="control">
149-
<input type="password" name="password_confirmation" title="<?php /* @escapeNotVerified */ echo __('Confirm Password') ?>" id="password-confirmation" class="input-text" data-validate="{required:true, equalTo:'#password'}">
149+
<input type="password" name="password_confirmation" title="<?php /* @escapeNotVerified */ echo __('Confirm Password') ?>" id="password-confirmation" class="input-text" data-validate="{required:true, equalTo:'#password'}" autocomplete="off">
150150
</div>
151151
</div>
152152
<?php echo $block->getChildHtml('form_additional_info'); ?>

app/code/Magento/Customer/view/frontend/templates/form/resetforgottenpassword.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@
1818
<div class="field password required">
1919
<label class="label" for="password"><span><?php /* @escapeNotVerified */ echo __('New Password'); ?></span></label>
2020
<div class="control">
21-
<input type="password" class="input-text" name="password" id="password" data-validate="{required:true, 'validate-password':true}">
21+
<input type="password" class="input-text" name="password" id="password" data-validate="{required:true, 'validate-password':true}" autocomplete="off">
2222
</div>
2323
</div>
2424
<div class="field confirmation required">
2525
<label class="label" for="password-confirmation"><span><?php /* @escapeNotVerified */ echo __('Confirm New Password'); ?></span></label>
2626
<div class="control">
27-
<input type="password" class="input-text" name="password_confirmation" id="password-confirmation" data-validate="{required:true,equalTo:'#password'}">
27+
<input type="password" class="input-text" name="password_confirmation" id="password-confirmation" data-validate="{required:true,equalTo:'#password'}" autocomplete="off">
2828
</div>
2929
</div>
3030
</fieldset>

app/code/Magento/Translation/Model/ResourceModel/StringUtils.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ public function saveTranslate($string, $translate, $locale = null, $storeId = nu
210210
{
211211
$connection = $this->getConnection();
212212
$table = $this->getMainTable();
213+
$translate = htmlspecialchars($translate, ENT_QUOTES);
213214

214215
if ($locale === null) {
215216
$locale = $this->_localeResolver->getLocale();

app/code/Magento/User/view/adminhtml/templates/admin/resetforgottenpassword.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@
1515
<div class="admin__field _required field-password">
1616
<label class="admin__field-label" for="password"><span><?php /* @escapeNotVerified */ echo __('New Password'); ?></span></label>
1717
<div class="admin__field-control">
18-
<input type="password" class="admin__control-text" data-validate="{required:true, 'validate-admin-password':true}" name="password" id="password" placeholder="new password" />
18+
<input type="password" class="admin__control-text" data-validate="{required:true, 'validate-admin-password':true}" name="password" id="password" placeholder="new password" autocomplete="off" />
1919
</div>
2020
</div>
2121
<div class="admin__field _required field-confirmation">
2222
<label class="admin__field-label" for="confirmation"><span><?php /* @escapeNotVerified */ echo __('Confirm New Password'); ?></span></label>
2323
<div class="admin__field-control">
24-
<input type="password" class="admin__control-text" data-validate="{required:true, 'validate-cpassword':true}" name="confirmation" id="confirmation" placeholder="confirm new password" />
24+
<input type="password" class="admin__control-text" data-validate="{required:true, 'validate-cpassword':true}" name="confirmation" id="confirmation" placeholder="confirm new password" autocomplete="off" />
2525
</div>
2626
</div>
2727
<div class="form-actions">

setup/view/magento/setup/system-config.phtml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@
9292
ng-class="{ 'invalid' : (auth.password.$error.required && !auth.password.$pristine)
9393
|| (auth.password.$error.required && user.submitted) }"
9494
required
95+
autocomplete="off"
9596
>
9697
<div class="error-container">
9798
This is a required field.

0 commit comments

Comments
 (0)