Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Commit 8a29cb2

Browse files
committed
Remove signals from RM::Repo
1 parent a0b3d77 commit 8a29cb2

File tree

3 files changed

+8
-20
lines changed

3 files changed

+8
-20
lines changed

Libs/libMacGitverCore/RepoMan/Frontend/Repo.cpp

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,8 @@ namespace RM
199199

200200
if (d->mDisplayAlias != alias) {
201201
d->mDisplayAlias = alias;
202-
emit aliasChanged(alias);
202+
// ###REPOMAN Create new Event "RepoAliasChanged"
203+
// emit aliasChanged(alias);
203204
}
204205
}
205206

@@ -218,7 +219,6 @@ namespace RM
218219
}
219220

220221
Events::self()->repositoryAboutToClose(this);
221-
emit aboutToClose(this);
222222

223223
foreach (Repo* child, submodules()) {
224224
child->close();
@@ -421,13 +421,10 @@ namespace RM
421421
mUnloadTimer = NULL;
422422
}
423423

424-
Repo* r = pub<Repo>();
425-
emit r->aboutToUnload(r);
426-
424+
// ####REPOMAN Do we really need to send out events for Unload/Load? If yes, create
425+
// real events for that!
427426
mIsLoaded = false;
428427
mRepo = Git::Repository();
429-
430-
emit r->unloaded(r);
431428
}
432429

433430

@@ -474,10 +471,7 @@ namespace RM
474471

475472
subInfo = repoByPath(path, true);
476473
if (!subInfo) {
477-
478474
subInfo = new Submodule(subRepo, p);
479-
emit p->childAdded(p, subInfo);
480-
481475
}
482476
else {
483477
oldSubmodules.remove(subInfo);

Libs/libMacGitverCore/RepoMan/Repo.hpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,6 @@ namespace RM
9898

9999
private slots:
100100
void unloadTimer();
101-
102-
signals:
103-
void aboutToClose (RM::Repo* repo);
104-
void aboutToUnload (RM::Repo* repo);
105-
void unloaded (RM::Repo* repo);
106-
void loaded (RM::Repo* repo);
107-
void childAdded (RM::Repo* parent, RM::Repo* child);
108-
void aliasChanged (const QString& newAlias);
109101
};
110102

111103
}

Modules/Repository/RepoInfoModel.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,13 @@ void RepoInfoModel::repositoryOpened(RM::Repo *info)
197197
return;
198198
}
199199

200+
// ###REPOMAN Instead of this, listen to SubmoduleCreated events
201+
200202
// This connection is wrong. There could be any children added below the repository (i.e.
201203
// HEAD, SubModule, CollectionNode). But the slot will unconditionally reserve a new space
202204
// for a submodule...
203-
connect(info, &RM::Repo::childAdded,
204-
this, &RepoInfoModel::repositoryChildAdded);
205+
//connect(info, &RM::Repo::childAdded,
206+
// this, &RepoInfoModel::repositoryChildAdded);
205207

206208
// we add a row just at the end of the root. This is stupid. But that's the way it works when
207209
// a model actually isn't a model...

0 commit comments

Comments
 (0)