Skip to content

Commit 4384cff

Browse files
author
James Lambert
committed
Ignore private annotation for constructors
1 parent 64b8c88 commit 4384cff

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/com/google/javascript/clutz/DeclarationGenerator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -647,7 +647,7 @@ private int declareNamespace(String namespace, TypedVar symbol, String emitName,
647647
emitNamespaceBegin(namespace);
648648
TreeWalker treeWalker = new TreeWalker(compiler.getTypeRegistry(), provides, isExtern);
649649
if (isDefault) {
650-
if (isPrivate(symbol.getJSDocInfo())) {
650+
if (isPrivate(symbol.getJSDocInfo()) && !symbol.getJSDocInfo().isConstructor()) {
651651
treeWalker.emitPrivateValue(emitName);
652652
} else {
653653
treeWalker.walk(symbol, emitName);
@@ -1644,6 +1644,7 @@ && getSuperType(type) == null) {
16441644
// Constructors.
16451645
if (type.isConstructor() && (type).getParameters().iterator().hasNext()) {
16461646
maybeEmitJsDoc(type.getJSDocInfo(), /* ignoreParams */ false);
1647+
// TODO mark constuctor as private when source is annoated with @private for ts v2.0 and greater
16471648
emit("constructor");
16481649
visitFunctionParameters(type, false, classTemplateTypeNames);
16491650
emit(";");

0 commit comments

Comments
 (0)