Fix windows buildbot where warnings are errors. We had a switch statement where all enumerations were handled, but some compilers don't recognize this. Simplify the logic so that all compilers will know a return value is returned in all cases.

Greg Clayton · Greg Clayton · commit e50b286c9e75 · 2016-11-11T16:55:31.000Z
llvm-svn: 286600
diff --git a/llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h b/llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h
@@ -204,12 +204,9 @@ class DWARFUnit {
     return getDwarfOffsetByteSize();
   }
   uint8_t getDwarfOffsetByteSize() const {
-    switch (getFormat()) {
-    case dwarf::DwarfFormat::DWARF32:
-      return 4;
-    case dwarf::DwarfFormat::DWARF64:
+    if (getFormat() == dwarf::DwarfFormat::DWARF64)
       return 8;
-    }
+    return 4;
   }
   uint64_t getBaseAddress() const { return BaseAddr; }
 

Original file line number	Diff line number	Diff line change
`@@ -204,12 +204,9 @@ class DWARFUnit {`
`204`	`204`	`return getDwarfOffsetByteSize();`
`205`	`205`	`}`
`206`	`206`	`uint8_t getDwarfOffsetByteSize() const {`
`207`		`- switch (getFormat()) {`
`208`		`- case dwarf::DwarfFormat::DWARF32:`
`209`		`- return 4;`
`210`		`- case dwarf::DwarfFormat::DWARF64:`
	`207`	`+ if (getFormat() == dwarf::DwarfFormat::DWARF64)`
`211`	`208`	`return 8;`
`212`		`- }`
	`209`	`+ return 4;`
`213`	`210`	`}`
`214`	`211`	`uint64_t getBaseAddress() const { return BaseAddr; }`
`215`	`212`