Skip to content

Commit d2e7ee7

Browse files
committed
[SLP]Do not check for clustered loads only
Since SLP support "clusterization" of the non-load instructions, the restriction for reduced values for loads only should be removed to avoid compiler crash. Fixes #113516
1 parent 0aec4d2 commit d2e7ee7

File tree

2 files changed

+39
-1
lines changed

2 files changed

+39
-1
lines changed

llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16118,7 +16118,7 @@ BoUpSLP::vectorizeTree(const ExtraValueToDebugLocsMap &ExternallyUsedValues,
1611816118
for (Instruction *I : RemovedInsts) {
1611916119
const TreeEntry *IE = getTreeEntry(I);
1612016120
if (IE->Idx != 0 &&
16121-
!(VectorizableTree.front()->isGather() && isa<LoadInst>(I) &&
16121+
!(VectorizableTree.front()->isGather() &&
1612216122
!IE->UserTreeIndices.empty() &&
1612316123
any_of(IE->UserTreeIndices,
1612416124
[&](const EdgeInfo &EI) {
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
2+
; RUN: opt -S --passes=slp-vectorizer -mtriple=x86_64-unknown-linux-gnu < %s | FileCheck %s
3+
4+
define i1 @foo() {
5+
; CHECK-LABEL: define i1 @foo() {
6+
; CHECK-NEXT: [[ENTRY:.*:]]
7+
; CHECK-NEXT: [[TOBOOL_NOT_NOT509_I_2329_I_I:%.*]] = icmp ne i32 0, 0
8+
; CHECK-NEXT: [[STOREMERGE_2333_I_I:%.*]] = select i1 [[TOBOOL_NOT_NOT509_I_2329_I_I]], i32 0, i32 0
9+
; CHECK-NEXT: [[TOBOOL_NOT_NOT509_I_1_2_I_I:%.*]] = icmp ne i32 [[STOREMERGE_2333_I_I]], 0
10+
; CHECK-NEXT: [[TMP0:%.*]] = insertelement <8 x i1> poison, i1 [[TOBOOL_NOT_NOT509_I_1_2_I_I]], i32 4
11+
; CHECK-NEXT: [[TMP1:%.*]] = insertelement <8 x i1> [[TMP0]], i1 [[TOBOOL_NOT_NOT509_I_2329_I_I]], i32 5
12+
; CHECK-NEXT: [[TMP2:%.*]] = call <8 x i1> @llvm.vector.insert.v8i1.v4i1(<8 x i1> [[TMP1]], <4 x i1> zeroinitializer, i64 0)
13+
; CHECK-NEXT: [[TMP3:%.*]] = call <8 x i1> @llvm.vector.insert.v8i1.v2i1(<8 x i1> [[TMP2]], <2 x i1> zeroinitializer, i64 6)
14+
; CHECK-NEXT: [[TMP4:%.*]] = freeze <8 x i1> [[TMP3]]
15+
; CHECK-NEXT: [[TMP5:%.*]] = call i1 @llvm.vector.reduce.and.v8i1(<8 x i1> [[TMP4]])
16+
; CHECK-NEXT: [[OP_RDX:%.*]] = select i1 false, i1 [[TMP5]], i1 false
17+
; CHECK-NEXT: ret i1 [[OP_RDX]]
18+
;
19+
entry:
20+
%tobool.not.not509.i.1311.i.i = icmp ne i32 0, 0
21+
%cmp80.1319.i.i189 = icmp sgt i32 0, 0
22+
%tobool.not.not509.i.1.1.i.i = icmp ne i32 0, 0
23+
%cmp80.1.1.i.i190 = icmp sgt i32 0, 0
24+
%tobool.not.not509.i.2329.i.i = icmp ne i32 0, 0
25+
%storemerge.2333.i.i = select i1 %tobool.not.not509.i.2329.i.i, i32 0, i32 0
26+
%cmp80.2337.i.i192 = icmp sgt i32 0, 0
27+
%tobool.not.not509.i.1.2.i.i = icmp ne i32 %storemerge.2333.i.i, 0
28+
%cmp80.1.2.i.i193 = icmp sgt i32 0, 0
29+
%cmp80.1.2.i.i = select i1 %tobool.not.not509.i.1.2.i.i, i1 %cmp80.1.2.i.i193, i1 false
30+
%0 = select i1 %cmp80.1.2.i.i, i1 %tobool.not.not509.i.2329.i.i, i1 false
31+
%1 = select i1 %0, i1 %cmp80.2337.i.i192, i1 false
32+
%2 = select i1 %1, i1 false, i1 false
33+
%3 = select i1 %2, i1 %tobool.not.not509.i.1.1.i.i, i1 false
34+
%4 = select i1 %3, i1 %cmp80.1.1.i.i190, i1 false
35+
%5 = select i1 %4, i1 %tobool.not.not509.i.1311.i.i, i1 false
36+
%6 = select i1 %5, i1 %cmp80.1319.i.i189, i1 false
37+
ret i1 %6
38+
}

0 commit comments

Comments
 (0)