Skip to content

Commit b3e64fb

Browse files
committed
[ARM] Prepare for VariantKind to specifier rename. NFC
1 parent e1a1603 commit b3e64fb

File tree

3 files changed

+15
-17
lines changed

3 files changed

+15
-17
lines changed

llvm/lib/Target/ARM/ARMMCInstLower.cpp

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -37,41 +37,38 @@ using namespace llvm;
3737

3838
MCOperand ARMAsmPrinter::GetSymbolRef(const MachineOperand &MO,
3939
const MCSymbol *Symbol) {
40-
MCSymbolRefExpr::VariantKind SymbolVariant = MCSymbolRefExpr::VK_None;
40+
MCSymbolRefExpr::VariantKind Specifier = MCSymbolRefExpr::VK_None;
4141
if (MO.getTargetFlags() & ARMII::MO_SBREL)
42-
SymbolVariant = MCSymbolRefExpr::VK_ARM_SBREL;
42+
Specifier = MCSymbolRefExpr::VK_ARM_SBREL;
4343

44-
const MCExpr *Expr =
45-
MCSymbolRefExpr::create(Symbol, SymbolVariant, OutContext);
44+
const MCExpr *Expr = MCSymbolRefExpr::create(Symbol, Specifier, OutContext);
4645
switch (MO.getTargetFlags() & ARMII::MO_OPTION_MASK) {
4746
default:
4847
llvm_unreachable("Unknown target flag on symbol operand");
4948
case ARMII::MO_NO_FLAG:
5049
break;
5150
case ARMII::MO_LO16:
52-
Expr =
53-
MCSymbolRefExpr::create(Symbol, SymbolVariant, OutContext);
51+
Expr = MCSymbolRefExpr::create(Symbol, Specifier, OutContext);
5452
Expr = ARMMCExpr::createLower16(Expr, OutContext);
5553
break;
5654
case ARMII::MO_HI16:
57-
Expr =
58-
MCSymbolRefExpr::create(Symbol, SymbolVariant, OutContext);
55+
Expr = MCSymbolRefExpr::create(Symbol, Specifier, OutContext);
5956
Expr = ARMMCExpr::createUpper16(Expr, OutContext);
6057
break;
6158
case ARMII::MO_LO_0_7:
62-
Expr = MCSymbolRefExpr::create(Symbol, SymbolVariant, OutContext);
59+
Expr = MCSymbolRefExpr::create(Symbol, Specifier, OutContext);
6360
Expr = ARMMCExpr::createLower0_7(Expr, OutContext);
6461
break;
6562
case ARMII::MO_LO_8_15:
66-
Expr = MCSymbolRefExpr::create(Symbol, SymbolVariant, OutContext);
63+
Expr = MCSymbolRefExpr::create(Symbol, Specifier, OutContext);
6764
Expr = ARMMCExpr::createLower8_15(Expr, OutContext);
6865
break;
6966
case ARMII::MO_HI_0_7:
70-
Expr = MCSymbolRefExpr::create(Symbol, SymbolVariant, OutContext);
67+
Expr = MCSymbolRefExpr::create(Symbol, Specifier, OutContext);
7168
Expr = ARMMCExpr::createUpper0_7(Expr, OutContext);
7269
break;
7370
case ARMII::MO_HI_8_15:
74-
Expr = MCSymbolRefExpr::create(Symbol, SymbolVariant, OutContext);
71+
Expr = MCSymbolRefExpr::create(Symbol, Specifier, OutContext);
7572
Expr = ARMMCExpr::createUpper8_15(Expr, OutContext);
7673
break;
7774
}

llvm/lib/Target/ARM/ARMTargetObjectFile.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ using namespace dwarf;
2828
// ELF Target
2929
//===----------------------------------------------------------------------===//
3030

31+
ARMElfTargetObjectFile::ARMElfTargetObjectFile() {
32+
PLTRelativeVariantKind = MCSymbolRefExpr::VK_ARM_PREL31;
33+
SupportIndirectSymViaGOTPCRel = true;
34+
}
35+
3136
void ARMElfTargetObjectFile::Initialize(MCContext &Ctx,
3237
const TargetMachine &TM) {
3338
const ARMBaseTargetMachine &ARM_TM = static_cast<const ARMBaseTargetMachine &>(TM);

llvm/lib/Target/ARM/ARMTargetObjectFile.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,7 @@ namespace llvm {
1717

1818
class ARMElfTargetObjectFile : public TargetLoweringObjectFileELF {
1919
public:
20-
ARMElfTargetObjectFile() {
21-
PLTRelativeVariantKind = MCSymbolRefExpr::VK_ARM_PREL31;
22-
SupportIndirectSymViaGOTPCRel = true;
23-
}
24-
20+
ARMElfTargetObjectFile();
2521
void Initialize(MCContext &Ctx, const TargetMachine &TM) override;
2622

2723
MCRegister getStaticBase() const override;

0 commit comments

Comments
 (0)