Skip to content

Commit b246d5f

Browse files
committed
Disable symbol versions for clang-cpp also with MSVC
It seems we can get there with MSVC if LLVM_BUILD_LLVM_DYLIB_VIS is set. Slightly surprising because I didn't know that MSVC supports the flag -Bsymbolic-functions, but let's play it safe.
1 parent 8234c61 commit b246d5f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

clang/tools/clang-shlib/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ add_clang_library(clang-cpp
5151

5252
configure_file(simple_version_script.map.in simple_version_script.map)
5353

54-
if (NOT APPLE AND NOT MINGW AND NOT LLVM_LINKER_IS_SOLARISLD)
54+
if (NOT APPLE AND NOT MSVC AND NOT MINGW AND NOT LLVM_LINKER_IS_SOLARISLD)
5555
# Solaris ld does not accept global: *; so there is no way to version *all* global symbols
5656
target_link_options(clang-cpp PRIVATE LINKER:--version-script,${CMAKE_CURRENT_BINARY_DIR}/simple_version_script.map)
5757
endif()

0 commit comments

Comments
 (0)