Skip to content

Commit a4367d2

Browse files
[lldb] Support tests with nested make invocations on Windows 1/2 (#112342)
In recent PR #111531 for Windows support, we enabled tests that require the `make` tool. On Windows, default install directories likely contain spaces, in this case e.g. `C:\Program Files (x86)\GnuWin32\bin\make.exe`. It's typically handled well by CMake, so that today invocations from `dotest.py` don't cause issues. However, we also have nested invocations from a number of Makefiles themselves. These still failed if the path to the `make` tool contains spaces. This patch attempts to fix the functionalities/completion test by adding quotes in the respective Makefile. If it keeps passing on the bots, we can roll out the fix to all affected tests.
1 parent 3187a49 commit a4367d2

File tree

1 file changed

+1
-1
lines changed
  • lldb/test/API/functionalities/completion

1 file changed

+1
-1
lines changed

lldb/test/API/functionalities/completion/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ USE_LIBDL := 1
44
a.out: lib_shared
55

66
lib_shared:
7-
$(MAKE) -f $(MAKEFILE_RULES) \
7+
"$(MAKE)" -f $(MAKEFILE_RULES) \
88
DYLIB_ONLY=YES DYLIB_CXX_SOURCES=shared.cpp DYLIB_NAME=shared
99

1010
include Makefile.rules

0 commit comments

Comments
 (0)