Skip to content

Commit 71d90f3

Browse files
committed
[AVR] Optimize 8-bit rotation when rotation bits == 3
Fixes #63100 Reviewed By: aykevl Differential Revision: https://reviews.llvm.org/D152365
1 parent e21df82 commit 71d90f3

File tree

2 files changed

+19
-15
lines changed

2 files changed

+19
-15
lines changed

llvm/lib/Target/AVR/AVRISelLowering.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -427,6 +427,18 @@ SDValue AVRTargetLowering::LowerShifts(SDValue Op, SelectionDAG &DAG) const {
427427
Victim = DAG.getNode(AVRISD::ASRBN, dl, VT, Victim,
428428
DAG.getConstant(7, dl, VT));
429429
ShiftAmount = 0;
430+
} else if (Op.getOpcode() == ISD::ROTL && ShiftAmount == 3) {
431+
// Optimize left rotation 3 bits to swap then right rotation 1 bit.
432+
Victim = DAG.getNode(AVRISD::SWAP, dl, VT, Victim);
433+
Victim =
434+
DAG.getNode(AVRISD::ROR, dl, VT, Victim, DAG.getConstant(1, dl, VT));
435+
ShiftAmount = 0;
436+
} else if (Op.getOpcode() == ISD::ROTR && ShiftAmount == 3) {
437+
// Optimize right rotation 3 bits to swap then left rotation 1 bit.
438+
Victim = DAG.getNode(AVRISD::SWAP, dl, VT, Victim);
439+
Victim =
440+
DAG.getNode(AVRISD::ROL, dl, VT, Victim, DAG.getConstant(1, dl, VT));
441+
ShiftAmount = 0;
430442
} else if (Op.getOpcode() == ISD::ROTL && ShiftAmount == 7) {
431443
// Optimize left rotation 7 bits to right rotation 1 bit.
432444
Victim =

llvm/test/CodeGen/AVR/rotate.ll

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,10 @@ start:
1515
define i8 @rotl8_3(i8 %x) {
1616
; CHECK-LABEL: rotl8_3:
1717
; CHECK: ; %bb.0: ; %start
18-
; CHECK-NEXT: lsl r24
19-
; CHECK-NEXT: adc r24, r1
20-
; CHECK-NEXT: lsl r24
21-
; CHECK-NEXT: adc r24, r1
22-
; CHECK-NEXT: lsl r24
23-
; CHECK-NEXT: adc r24, r1
18+
; CHECK-NEXT: swap r24
19+
; CHECK-NEXT: bst r24, 0
20+
; CHECK-NEXT: ror r24
21+
; CHECK-NEXT: bld r24, 7
2422
; CHECK-NEXT: ret
2523
start:
2624
%0 = call i8 @llvm.fshl.i8(i8 %x, i8 %x, i8 3)
@@ -85,15 +83,9 @@ start:
8583
define i8 @rotr8_3(i8 %x) {
8684
; CHECK-LABEL: rotr8_3:
8785
; CHECK: ; %bb.0: ; %start
88-
; CHECK-NEXT: bst r24, 0
89-
; CHECK-NEXT: ror r24
90-
; CHECK-NEXT: bld r24, 7
91-
; CHECK-NEXT: bst r24, 0
92-
; CHECK-NEXT: ror r24
93-
; CHECK-NEXT: bld r24, 7
94-
; CHECK-NEXT: bst r24, 0
95-
; CHECK-NEXT: ror r24
96-
; CHECK-NEXT: bld r24, 7
86+
; CHECK-NEXT: swap r24
87+
; CHECK-NEXT: lsl r24
88+
; CHECK-NEXT: adc r24, r1
9789
; CHECK-NEXT: ret
9890
start:
9991
%0 = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 3)

0 commit comments

Comments
 (0)