Skip to content

Commit 654086c

Browse files
committed
[lldb/Plugins] Move SymbolFileDWARFDebugMap into SymbolFileDWARF (NFCI)
Move the logic for initialization and termination for SymbolFileDWARFDebugMap into SymbolFileDWARF so that there's one initializer for the SymbolFileDWARF plugin.
1 parent 90a94c0 commit 654086c

File tree

4 files changed

+2
-8
lines changed

4 files changed

+2
-8
lines changed

lldb/source/API/SystemInitializerFull.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ LLDB_PLUGIN_DECLARE(EmulateInstructionARM64)
8888
LLDB_PLUGIN_DECLARE(EmulateInstructionMIPS)
8989
LLDB_PLUGIN_DECLARE(EmulateInstructionMIPS64)
9090
LLDB_PLUGIN_DECLARE(EmulateInstructionPPC64)
91-
LLDB_PLUGIN_DECLARE(SymbolFileDWARFDebugMap)
9291
LLDB_PLUGIN_DECLARE(ItaniumABILanguageRuntime)
9392
LLDB_PLUGIN_DECLARE(AppleObjCRuntime)
9493
LLDB_PLUGIN_DECLARE(SystemRuntimeMacOSX)
@@ -230,7 +229,6 @@ llvm::Error SystemInitializerFull::Initialize() {
230229
LLDB_PLUGIN_INITIALIZE(EmulateInstructionMIPS64);
231230
LLDB_PLUGIN_INITIALIZE(EmulateInstructionPPC64);
232231

233-
LLDB_PLUGIN_INITIALIZE(SymbolFileDWARFDebugMap);
234232
LLDB_PLUGIN_INITIALIZE(ItaniumABILanguageRuntime);
235233
LLDB_PLUGIN_INITIALIZE(AppleObjCRuntime);
236234
LLDB_PLUGIN_INITIALIZE(SystemRuntimeMacOSX);
@@ -324,7 +322,6 @@ void SystemInitializerFull::Terminate() {
324322
LLDB_PLUGIN_TERMINATE(EmulateInstructionMIPS64);
325323
LLDB_PLUGIN_TERMINATE(EmulateInstructionPPC64);
326324

327-
LLDB_PLUGIN_TERMINATE(SymbolFileDWARFDebugMap);
328325
LLDB_PLUGIN_TERMINATE(ItaniumABILanguageRuntime);
329326
LLDB_PLUGIN_TERMINATE(AppleObjCRuntime);
330327
LLDB_PLUGIN_TERMINATE(SystemRuntimeMacOSX);

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ void SymbolFileDWARF::Initialize() {
226226
PluginManager::RegisterPlugin(GetPluginNameStatic(),
227227
GetPluginDescriptionStatic(), CreateInstance,
228228
DebuggerInitialize);
229+
SymbolFileDWARFDebugMap::Initialize();
229230
}
230231

231232
void SymbolFileDWARF::DebuggerInitialize(Debugger &debugger) {
@@ -240,6 +241,7 @@ void SymbolFileDWARF::DebuggerInitialize(Debugger &debugger) {
240241
}
241242

242243
void SymbolFileDWARF::Terminate() {
244+
SymbolFileDWARFDebugMap::Terminate();
243245
PluginManager::UnregisterPlugin(CreateInstance);
244246
LogChannelDWARF::Terminate();
245247
}

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@
3939
using namespace lldb;
4040
using namespace lldb_private;
4141

42-
LLDB_PLUGIN(SymbolFileDWARFDebugMap)
43-
4442
char SymbolFileDWARFDebugMap::ID;
4543

4644
// Subclass lldb_private::Module so we can intercept the

lldb/tools/lldb-test/SystemInitializerTest.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ LLDB_PLUGIN_DECLARE(EmulateInstructionARM64)
7474
LLDB_PLUGIN_DECLARE(EmulateInstructionMIPS)
7575
LLDB_PLUGIN_DECLARE(EmulateInstructionMIPS64)
7676
LLDB_PLUGIN_DECLARE(EmulateInstructionPPC64)
77-
LLDB_PLUGIN_DECLARE(SymbolFileDWARFDebugMap)
7877
LLDB_PLUGIN_DECLARE(ItaniumABILanguageRuntime)
7978
LLDB_PLUGIN_DECLARE(AppleObjCRuntime)
8079
LLDB_PLUGIN_DECLARE(SystemRuntimeMacOSX)
@@ -205,7 +204,6 @@ llvm::Error SystemInitializerTest::Initialize() {
205204
LLDB_PLUGIN_INITIALIZE(EmulateInstructionMIPS64);
206205
LLDB_PLUGIN_INITIALIZE(EmulateInstructionPPC64);
207206

208-
LLDB_PLUGIN_INITIALIZE(SymbolFileDWARFDebugMap);
209207
LLDB_PLUGIN_INITIALIZE(ItaniumABILanguageRuntime);
210208
LLDB_PLUGIN_INITIALIZE(AppleObjCRuntime);
211209
LLDB_PLUGIN_INITIALIZE(SystemRuntimeMacOSX);
@@ -299,7 +297,6 @@ void SystemInitializerTest::Terminate() {
299297
LLDB_PLUGIN_TERMINATE(EmulateInstructionMIPS64);
300298
LLDB_PLUGIN_TERMINATE(EmulateInstructionPPC64);
301299

302-
LLDB_PLUGIN_TERMINATE(SymbolFileDWARFDebugMap);
303300
LLDB_PLUGIN_TERMINATE(ItaniumABILanguageRuntime);
304301
LLDB_PLUGIN_TERMINATE(AppleObjCRuntime);
305302
LLDB_PLUGIN_TERMINATE(SystemRuntimeMacOSX);

0 commit comments

Comments
 (0)