Skip to content

Commit 02230e1

Browse files
[NewPM] Remove AAEval Legacy Pass (#71358)
This patch removes the AAEval legacy pass and associated plumbing. This pass was migrated over to the new pass manager about 11 years ago at this point and there are currently no in-tree users of the legacy pass, so it's essentially just dead code and is completely untested.
1 parent 317481b commit 02230e1

File tree

5 files changed

+0
-54
lines changed

5 files changed

+0
-54
lines changed

llvm/include/llvm/Analysis/AliasAnalysisEvaluator.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,8 @@ class AAEvaluator : public PassInfoMixin<AAEvaluator> {
5454
PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM);
5555

5656
private:
57-
// Allow the legacy pass to run this using an internal API.
58-
friend class AAEvalLegacyPass;
59-
6057
void runInternal(Function &F, AAResults &AA);
6158
};
62-
63-
/// Create a wrapper of the above for the legacy pass manager.
64-
FunctionPass *createAAEvalPass();
65-
6659
}
6760

6861
#endif

llvm/include/llvm/InitializePasses.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ void initializeGlobalISel(PassRegistry&);
4848
/// Initialize all passes linked into the CodeGen library.
4949
void initializeTarget(PassRegistry&);
5050

51-
void initializeAAEvalLegacyPassPass(PassRegistry&);
5251
void initializeAAResultsWrapperPassPass(PassRegistry&);
5352
void initializeAlwaysInlinerLegacyPassPass(PassRegistry&);
5453
void initializeAssignmentTrackingAnalysisPass(PassRegistry &);

llvm/include/llvm/LinkAllPasses.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ namespace {
6161
if (std::getenv("bar") != (char*) -1)
6262
return;
6363

64-
(void) llvm::createAAEvalPass();
6564
(void) llvm::createBasicAAWrapperPass();
6665
(void) llvm::createSCEVAAWrapperPass();
6766
(void) llvm::createTypeBasedAAWrapperPass();

llvm/lib/Analysis/AliasAnalysisEvaluator.cpp

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
#include "llvm/IR/InstIterator.h"
1515
#include "llvm/IR/Instructions.h"
1616
#include "llvm/IR/Module.h"
17-
#include "llvm/InitializePasses.h"
18-
#include "llvm/Pass.h"
1917
#include "llvm/Support/CommandLine.h"
2018
#include "llvm/Support/raw_ostream.h"
2119
using namespace llvm;
@@ -319,45 +317,3 @@ AAEvaluator::~AAEvaluator() {
319317
<< "%/" << ModRefCount * 100 / ModRefSum << "%\n";
320318
}
321319
}
322-
323-
namespace llvm {
324-
class AAEvalLegacyPass : public FunctionPass {
325-
std::unique_ptr<AAEvaluator> P;
326-
327-
public:
328-
static char ID; // Pass identification, replacement for typeid
329-
AAEvalLegacyPass() : FunctionPass(ID) {
330-
initializeAAEvalLegacyPassPass(*PassRegistry::getPassRegistry());
331-
}
332-
333-
void getAnalysisUsage(AnalysisUsage &AU) const override {
334-
AU.addRequired<AAResultsWrapperPass>();
335-
AU.setPreservesAll();
336-
}
337-
338-
bool doInitialization(Module &M) override {
339-
P.reset(new AAEvaluator());
340-
return false;
341-
}
342-
343-
bool runOnFunction(Function &F) override {
344-
P->runInternal(F, getAnalysis<AAResultsWrapperPass>().getAAResults());
345-
return false;
346-
}
347-
bool doFinalization(Module &M) override {
348-
P.reset();
349-
return false;
350-
}
351-
};
352-
}
353-
354-
char AAEvalLegacyPass::ID = 0;
355-
INITIALIZE_PASS_BEGIN(AAEvalLegacyPass, "aa-eval",
356-
"Exhaustive Alias Analysis Precision Evaluator", false,
357-
true)
358-
INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass)
359-
INITIALIZE_PASS_END(AAEvalLegacyPass, "aa-eval",
360-
"Exhaustive Alias Analysis Precision Evaluator", false,
361-
true)
362-
363-
FunctionPass *llvm::createAAEvalPass() { return new AAEvalLegacyPass(); }

llvm/lib/Analysis/Analysis.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ using namespace llvm;
1818

1919
/// initializeAnalysis - Initialize all passes linked into the Analysis library.
2020
void llvm::initializeAnalysis(PassRegistry &Registry) {
21-
initializeAAEvalLegacyPassPass(Registry);
2221
initializeBasicAAWrapperPassPass(Registry);
2322
initializeBlockFrequencyInfoWrapperPassPass(Registry);
2423
initializeBranchProbabilityInfoWrapperPassPass(Registry);

0 commit comments

Comments
 (0)