Skip to content

Commit 27d43d1

Browse files
ChuanqiXu9AlexisPerry
authored andcommitted
[Serialization] Revert specialization for DenseMapInfo<GlobalDeclID>::getHashValue
The FIXME says to revert this when the underlying issue got fixed. And now the underlying issue got fixed in llvm#95734. So I think it should be fine to rever that one now.
1 parent 36b4a5b commit 27d43d1

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

clang/include/clang/AST/DeclID.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -259,11 +259,7 @@ template <> struct DenseMapInfo<clang::GlobalDeclID> {
259259
}
260260

261261
static unsigned getHashValue(const GlobalDeclID &Key) {
262-
// Our default hash algorithm for 64 bits integer may not be very good.
263-
// In GlobalDeclID's case, it is pretty common that the lower 32 bits can
264-
// be same.
265-
// FIXME: Remove this when we fix the underlying issue.
266-
return llvm::hash_value(Key.getRawValue());
262+
return DenseMapInfo<DeclID>::getHashValue(Key.getRawValue());
267263
}
268264

269265
static bool isEqual(const GlobalDeclID &L, const GlobalDeclID &R) {

0 commit comments

Comments
 (0)