Skip to content

Commit f7a4345

Browse files
committed
chore(service-profiles): remove Default bounds
see linkerd/linkerd2#8733 for more information. see also, #3651 #3653, #3654, and #3655 for some related pull requests. in hyper 1.x, `Incoming` bodies do not provide a `Default` implementation. compare the trait implementations here: * https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body * https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations this commit removes `Default` bounds from `Client<R, S>` used to create watches on service profiles. Signed-off-by: katelyn martin <[email protected]>
1 parent ea8a970 commit f7a4345

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

linkerd/service-profiles/src/client.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ impl<R, S> Client<R, S>
3333
where
3434
S: GrpcService<BoxBody> + Clone + Send + 'static,
3535
S::ResponseBody: Send + Sync,
36-
S::ResponseBody: Default + Body<Data = tonic::codegen::Bytes> + Send + 'static,
36+
S::ResponseBody: Body<Data = tonic::codegen::Bytes> + Send + 'static,
3737
<S::ResponseBody as Body>::Error:
3838
Into<Box<dyn std::error::Error + Send + Sync + 'static>> + Send,
3939
S::Future: Send,
@@ -65,7 +65,7 @@ impl<T, R, S> Service<T> for Client<R, S>
6565
where
6666
T: Param<LookupAddr>,
6767
S: GrpcService<BoxBody> + Clone + Send + 'static,
68-
S::ResponseBody: Default + Body<Data = tonic::codegen::Bytes> + Send + 'static,
68+
S::ResponseBody: Body<Data = tonic::codegen::Bytes> + Send + 'static,
6969
<S::ResponseBody as Body>::Error:
7070
Into<Box<dyn std::error::Error + Send + Sync + 'static>> + Send,
7171
S::Future: Send,
@@ -112,7 +112,7 @@ type InnerFuture =
112112
impl<S> Inner<S>
113113
where
114114
S: GrpcService<BoxBody> + Clone + Send + 'static,
115-
S::ResponseBody: Default + Body<Data = tonic::codegen::Bytes> + Send + 'static,
115+
S::ResponseBody: Body<Data = tonic::codegen::Bytes> + Send + 'static,
116116
<S::ResponseBody as Body>::Error:
117117
Into<Box<dyn std::error::Error + Send + Sync + 'static>> + Send,
118118
S::Future: Send,
@@ -129,7 +129,7 @@ where
129129
impl<S> Service<LookupAddr> for Inner<S>
130130
where
131131
S: GrpcService<BoxBody> + Clone + Send + 'static,
132-
S::ResponseBody: Default + Body<Data = tonic::codegen::Bytes> + Send + 'static,
132+
S::ResponseBody: Body<Data = tonic::codegen::Bytes> + Send + 'static,
133133
<S::ResponseBody as Body>::Error:
134134
Into<Box<dyn std::error::Error + Send + Sync + 'static>> + Send,
135135
S::Future: Send,

0 commit comments

Comments
 (0)