Skip to content

Shouldn't the autopilot with several heuristics use the Harmonic mean instead of the Arithmetic one? #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renepickhardt opened this issue Feb 20, 2019 · 1 comment

Comments

@renepickhardt
Copy link

renepickhardt commented Feb 20, 2019

I found this line in your autopilot which combines several heuristics for the autopilot:

score.Score += h.Weight * sub.Score

As far as I understand the scores are always supposed to be normalized which should mean that we are talking about rates. According to the Wikipedia article about the Harmonic mean this seems to be a better candidate than the arithmetic mean that is currently being used:

In mathematics, the harmonic mean [...] is appropriate for situations when the average of rates is desired.

The formula for a weighted harmonic mean can also be found in the wikipedia article:

codecogseqn

If you agree I would implement the weighted harmonic mean and exchange the current average and issue a pull request.

fyi: @alexbosworth @halseth

@halseth
Copy link
Contributor

halseth commented Apr 26, 2019

@renepickhardt The scores are in the range [0,1], not sure if that qualifies as a rate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants