Skip to content

Stop completing monitor udpate completion actions when claiming on a closed channel #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheBlueMatt opened this issue Jun 14, 2023 · 1 comment

Comments

@TheBlueMatt
Copy link
Collaborator

Remove this hunk and track them globally:

        // Note that we do process the completion action here. This totally could be a
        // duplicate claim, but we have no way of knowing without interrogating the
        // `ChannelMonitor` we've provided the above update to. Instead, note that `Event`s are
        // generally always allowed to be duplicative (and it's specifically noted in
        // `PaymentForwarded`).
        self.handle_monitor_update_completion_actions(completion_action(None));
@TheBlueMatt TheBlueMatt added this to the 0.0.117 milestone Jun 14, 2023
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.117, 0.0.118 Sep 13, 2023
@TheBlueMatt
Copy link
Collaborator Author

Slipping this, the documentation updates in #2562 explicitly state that the async mode is not yet fully supported, which is a reference to this and one other issue involving MPP claims across channels hitting tail latency implying loss of preimage on one channel before other channels hit disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant