Use Cow<'static, str> instead of String

Author: ghassmo

sqlx-core/src/sqlite/options/connect.rs

@@ -18,10 +18,14 @@ impl ConnectOptions for SqliteConnectOptions {
             let mut conn = establish(self).await?;
 
             // send an initial sql statement comprised of options
+            let mut init = String::new();
+
             for (key, value) in self.pragmas.iter() {
-                conn.execute(&*format!("PRAGMA {} = {};", key, value)).await?;
+                init += &format!("PRAGMA {} = {}; ", key, value);
             }
 
+            conn.execute(&*init).await?;
+
             Ok(conn)
         })
     }

sqlx-core/src/sqlite/options/mod.rs

@@ -59,7 +59,7 @@ pub struct SqliteConnectOptions {
     pub(crate) statement_cache_capacity: usize,
     pub(crate) busy_timeout: Duration,
     pub(crate) log_settings: LogSettings,
-    pub(crate) pragmas: IndexMap<String, String>,
+    pub(crate) pragmas: IndexMap<Cow<'static, str>, Cow<'static, str>>,
 }
 
 impl Default for SqliteConnectOptions {
@@ -71,14 +71,14 @@ impl Default for SqliteConnectOptions {
 impl SqliteConnectOptions {
     pub fn new() -> Self {
         // set default pragmas
-        let mut pragmas = IndexMap::new();
+        let mut pragmas: IndexMap<Cow<'static, str>, Cow<'static, str>> = IndexMap::new();
 
         let locking_mode: SqliteLockingMode = Default::default();
         let auto_vacuum: SqliteAutoVacuum = Default::default();
 
         // page_size must be set before any other action on the database.
-        pragmas.insert("page_size".into(), 4096.to_string());
-        
+        pragmas.insert("page_size".into(), "4096".into());
+
         // Note that locking_mode should be set before journal_mode; see
         // https://www.sqlite.org/wal.html#use_of_wal_without_shared_memory .
         pragmas.insert("locking_mode".into(), locking_mode.as_str().into());
@@ -209,17 +209,21 @@ impl SqliteConnectOptions {
         self
     }
 
-    /// Sets custom initial pragmas for the database connection.
-    pub fn pragma(mut self, key: &str, value: &str) -> Self {
-        self.pragmas.insert(key.into(), value.into());
-        self
-    }
-
     /// Sets the [page_size](https://www.sqlite.org/pragma.html#pragma_page_size) setting for the database connection.
     ///
     /// The default page_size setting is 4096.
     pub fn page_size(mut self, page_size: u32) -> Self {
-        self.pragmas.insert("page_size".into(), page_size.to_string());
+        self.pragmas
+            .insert("page_size".into(), page_size.to_string().into());
+        self
+    }
+
+    /// Sets custom initial pragma for the database connection.
+    pub fn pragma<T>(mut self, key: T, value: T) -> Self
+    where
+        T: Into<Cow<'static, str>>,
+    {
+        self.pragmas.insert(key.into(), value.into());
         self
     }
 }