You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR focuses on unblocking `strictNullChecks` and
`strictPropertyInitialization` in ecmascript.ts and calendar.ts.
It's intended as a complement to @jens-ox's work to remove
`GetIntrinsic`.
This PR:
* Enables strictNullChecks: true and strictPropertyInitialization: true
in tsconfig.json.
* Improves calendar.ts TS types (this was most of the work in this PR)
* Removes all unnecessary use of `any` throughout the polyfill
* Updates types of ecmascript.ts and fixes a number of type bugs
* Ports several proposal-temporal PRs:
* tc39/proposal-temporal#1975 - Refactors to
align ecmascript.mjs with spec text
* tc39/proposal-temporal#1974 - Ensure that
Temporal prototypes aren't writable
* tc39/proposal-temporal#1976 - Throw
RangeError if there's an invalid offset string in
ZonedDateTime-representing property bags
* tc39/proposal-temporal#1977 - Refactor
and fix non-ISO calendars in polyfill
* Fixes a few index.d.ts types
* Refactors a few types in intl.ts
* A handful of trivial type changes in other files (ecmascript.ts and
calendar-ts were 95%+ of the work).
I'd like to split out the runtime behavior changes (mostly the ported
PRs above) into a smaller PR which should make it easier to review
changes that can actually break things at runtime. I also need to port
tests over from tc39/proposal-temporal#1976.
Once those are split out, this PR should be ready to review.
0 commit comments