Skip to content

Commit c00e610

Browse files
author
Jason Williams
committed
removing --inspect as its no longer needed by the Nightly debugger (and causes issues) - See microsoft/vscode-js-debug#289
1 parent e0cdc33 commit c00e610

File tree

5 files changed

+11
-18
lines changed

5 files changed

+11
-18
lines changed

.vscode/launch.json

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,7 @@
66
"request": "launch",
77
"name": "launch server",
88
"runtimeExecutable": "node",
9-
"runtimeArgs": [
10-
"-r",
11-
"ts-node/register",
12-
"--inspect=9229",
13-
"server/index.ts"
14-
],
9+
"runtimeArgs": ["-r", "ts-node/register", "server/index.ts"],
1510
"env": {
1611
"TS_NODE_PROJECT": "tsconfig.server.json"
1712
},
@@ -38,7 +33,8 @@
3833
"request": "launch",
3934
"name": "Launch Chrome",
4035
"url": "http://localhost:3000",
41-
"webRoot": "${workspaceFolder}"
36+
"webRoot": "${workspaceFolder}",
37+
"trace": true
4238
},
4339
{
4440
"type": "edge",

.vscode/settings.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
{
2-
"debug.chrome.useV3": true
2+
"debug.chrome.useV3": true,
3+
"debug.node.useV3": true
34
}

README.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,13 @@ This is example of next app using express, typescript and next, that can be debu
44

55
### Prerequesites
66

7-
Due to https://github.com/microsoft/vscode-chrome-debug/issues/978 the [javascript debugger (nightly)](https://marketplace.visualstudio.com/items?itemName=ms-vscode.js-debug-nightly) plugin is needed.
7+
Due to [#978](https://github.com/microsoft/vscode-chrome-debug/issues/978) and [#289](https://github.com/microsoft/vscode-js-debug/issues/289) the [javascript debugger (nightly)](https://marketplace.visualstudio.com/items?itemName=ms-vscode.js-debug-nightly) plugin is needed.
88

9-
### As off @v1:
9+
As of lastets master:
1010

1111
- Chrome Works (v79.0.3945.130)
1212
- Edge Works (v79.0.309.71)
1313
- Firefox debugger does not work due to these 2 issues:
1414
- - https://github.com/zeit/next.js/issues/9471
1515
- - https://github.com/firefox-devtools/vscode-firefox-debug/issues/177
1616
- Server Side debugging works (Node v13.2.0)
17-
18-
### Outstanding issues
19-
20-
https://github.com/microsoft/vscode-js-debug/issues/289 - Server Side debugging is still a bit sketchy and not properly working with the new nightly debugger.

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
},
1414
"devDependencies": {
1515
"@types/express": "^4.17.2",
16-
"@types/node": "^13.1.2",
16+
"@types/node": "^13.7.0",
1717
"@types/react": "^16.9.17",
1818
"@types/react-dom": "^16.9.4",
1919
"ts-node": "^8.5.4",

0 commit comments

Comments
 (0)