Skip to content

Commit 28d26e8

Browse files
committed
Pass 'encoding' to target.open in test_open_text_FileNotFoundError. Fixes python#280.
1 parent ff16bd3 commit 28d26e8

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

CHANGES.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
v5.10.4
2+
=======
3+
4+
* #280: Fixed one more ``EncodingWarning`` in test suite.
5+
16
v5.10.3
27
=======
38

importlib_resources/tests/test_open.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,13 @@ def test_open_text_with_errors(self):
5656

5757
def test_open_binary_FileNotFoundError(self):
5858
target = resources.files(self.data) / 'does-not-exist'
59-
self.assertRaises(FileNotFoundError, target.open, 'rb')
59+
with self.assertRaises(FileNotFoundError):
60+
target.open('rb')
6061

6162
def test_open_text_FileNotFoundError(self):
6263
target = resources.files(self.data) / 'does-not-exist'
63-
self.assertRaises(FileNotFoundError, target.open)
64+
with self.assertRaises(FileNotFoundError):
65+
target.open(encoding='utf-8')
6466

6567

6668
class OpenDiskTests(OpenTests, unittest.TestCase):

0 commit comments

Comments
 (0)