-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add all rules config #1543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That would make adding a rule always be a breaking change; it wouldn't be valuable to have such a config. |
@ljharb That's what most set of rules do.
|
@akoidan adding a new rule to any plugin's config is always semver-major - that's how everyone in the ecosystem does it. Thus, an "all" config would also either not get new ones until the next major - just like "recommended" already does - or, would force a semver-major bump any time a rule is added. |
Is it?
New rules come withing minor versions and it's totally ok, you can:
|
Fair enough that eslint itself does it; you'll note the concerns in eslint/eslint#6248 :-) specifically, eslint/eslint#6248 (comment) You only have a lockfile if you have one; apps should have them but libraries shouldn't. Generally speaking, the only valid response here to "it's a breaking change" is "you don't have to use it", which is true. Can you explain why you want this? |
@ljharb I want the most arrgessive rules for by configuration as possible. Most of the things that I find useful, e.g. no-named-as-default usually don't come in recommended config.
It would be much easier (at least for me) if I could include all config and exclude rules which make me uncomfortable because they would |
The most aggressive possible configuration won't necessarily match the defaults; some rules can only be manually configured for your project and have no reasonable defaults - it seems like you might want to do what I do with the airbnb config, and configure them yourself, but use |
Some rules, e.g.
no-relative-parent-imports
are missing in default rule set. Lets create a config "plugin:import/all" that will include everything.This config doesn't produce all linting rules:
The text was updated successfully, but these errors were encountered: