Skip to content

Commit 9472be9

Browse files
committed
SessionUser protection against nil pointer dereference
`SessionUser` should be protected against passing `sess` = `nil` to avoid ``` PANIC: runtime error: invalid memory address or nil pointer dereference ``` in https://github.com/go-gitea/gitea/pull/18452/files#diff-a215b82aadeb8b4c4632fcf31215dd421f804eb1c0137ec6721b980136e4442aR69 after upgrade from gitea v1.16 to v1.17. Related: go-gitea#18452 Author-Change-Id: IB#1126459
1 parent 870d7f9 commit 9472be9

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

services/auth/session.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2019 The Gitea Authors. All rights reserved.
1+
// Copyright 2022 The Gitea Authors. All rights reserved.
22
// Use of this source code is governed by a MIT-style
33
// license that can be found in the LICENSE file.
44

@@ -39,6 +39,10 @@ func (s *Session) Verify(req *http.Request, w http.ResponseWriter, store DataSto
3939

4040
// SessionUser returns the user object corresponding to the "uid" session variable.
4141
func SessionUser(sess SessionStore) *user_model.User {
42+
if sess == nil {
43+
return nil
44+
}
45+
4246
// Get user ID
4347
uid := sess.Get("uid")
4448
if uid == nil {

0 commit comments

Comments
 (0)