Skip to content

Commit 184cd1b

Browse files
committed
Better reference management pattern
1 parent d7bb877 commit 184cd1b

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/PythonQt.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2137,8 +2137,9 @@ PyObject* PythonQtPrivate::packageByName(const char* name)
21372137
v = PyImport_AddModule((_pythonQtModuleName + "." + name).constData());
21382138
_packages.insert(name, v);
21392139
// AddObject steals the reference, so increment it!
2140-
Py_INCREF(v);
2141-
PyModule_AddObject(_pythonQtModule, name, v);
2140+
if (PyModule_AddObject(_pythonQtModule, name, v) == 0) {
2141+
Py_INCREF(v);
2142+
}
21422143
}
21432144
return v;
21442145
}

0 commit comments

Comments
 (0)