Add Win32 CI

Author: iakov

.github/workflows/build.yml

@@ -55,7 +55,7 @@ jobs:
         echo ============================
         qmake -r PythonQt.pro CONFIG+=release CONFIG+=sanitizer CONFIG+=sanitize_undefined \
         PYTHON_VERSION=$(python3 --version | cut -d " " -f 2 | cut -d "." -f1,2) \
-        PYTHON_DIR=$(which python3 | xargs dirname | xargs dirname)    
+        PYTHON_PATH=$(which python3 | xargs dirname)
         make -j 2 && make check TESTARGS="-platform offscreen"
       
     - name: Generate Wrappers
@@ -115,7 +115,7 @@ jobs:
         echo ============================
         qmake-qt5 -r PythonQt.pro CONFIG+=release \
         PYTHON_VERSION=$(python --version | cut -d " " -f 2 | cut -d "." -f1,2) \
-        PYTHON_DIR=$(which python | xargs dirname | xargs dirname)    
+        PYTHON_PATH=$(which python | xargs dirname)
         make -j 2 && make check TESTARGS="-platform offscreen"
       
     - name: Generate Wrappers
@@ -173,7 +173,7 @@ jobs:
         set -eu
         PYTHON_VERSION_FULL=$(python --version 2>&1 | cut -f 2 -d ' ')
         PYTHON_VERSION_SHORT=$(cut -f 1,2 -d . <<< $PYTHON_VERSION_FULL)
-        QT_VERSION_FULL=$($Qt5_DIR/bin/qmake -query QT_VERSION)
+        QT_VERSION_FULL=$($Qt5_Dir/bin/qmake -query QT_VERSION)
         QT_VERSION_SHORT=$(cut -f 1,2 -d . <<< $QT_VERSION_FULL)
         MACOS_VERSION_FULL=$(sw_vers -productVersion)
         MACOS_VERSION_SHORT=$(cut -f 1,2 -d . <<< $MACOS_VERSION_FULL)
@@ -197,7 +197,7 @@ jobs:
         do if pkg-config --exists "$i"; then PYTHON_PKGCONFIG_NAME="$i"; break; fi; done
         qmake CONFIG+=release CONFIG+=sanitizer CONFIG+=sanitize_undefined \
         PYTHON_VERSION=${{ steps.versions.outputs.PYTHON_VERSION_SHORT }} \
-        PYTHON_DIR="$pythonLocation" \
+        PYTHON_PATH="$pythonLocation" \
         PKGCONFIG+=$PYTHON_PKGCONFIG_NAME \
         -r PythonQt.pro
         make -j 2 && make check TESTARGS="-platform offscreen"
@@ -206,11 +206,114 @@ jobs:
       run: |
         cd generator
         # workaround to allow to find the Qt include dirs for installed standard qt packages
-        QTDIR=-UNDEFINED- ./pythonqt_generator --include-paths=$Qt5_DIR/lib
+        QTDIR=-UNDEFINED- ./pythonqt_generator --include-paths=$Qt5_Dir/lib
 
     - name: Upload Wrappers
       uses: actions/upload-artifact@v3
       with:
         name: wrappers_macos${{ steps.versions.outputs.MACOS_VERSION_SHORT }}_qt${{ steps.versions.outputs.QT_VERSION_SHORT }}
         path: generated_cpp
 
+  windows:
+    strategy:
+      fail-fast: false
+      matrix:
+       qt-arch: ['win32_msvc2015']
+       python-version: ['2.7']
+       qt-version: ['5.9.*']
+       python-arch: ['x86']
+       pythonqtall-config: ['PythonQtCore PythonQtGui PythonQtMultimedia']
+#       msvc-toolset: ['14.0']
+       include:
+         - qt-arch: 'win64_msvc2017_64'
+           python-version: '3.6'
+           python-arch: 'x64'
+           qt-version: '5.11.*'
+#           msvc-toolset: '14.16'
+
+         - qt-arch: 'win32_mingw53'
+           python-version: '2.7'
+           python-arch: 'x86'
+           qt-version: '5.11.*'
+
+         - qt-arch: 'win64_mingw73'
+           python-version: '3.10'
+           python-arch: 'x64'
+           qt-version: '5.12.*'
+           pythonqtall-config: ''
+
+    runs-on: windows-latest
+    steps:
+
+    - name: Checkout PythonQt
+      uses: actions/checkout@v3
+
+    - name: Reset PATH
+      uses: egor-tensin/cleanup-path@v3
+
+    - name: Install MSVC++
+      uses: ilammy/msvc-dev-cmd@v1
+      if: ${{ contains(matrix.qt-arch, 'msvc') }}
+      with:
+        arch: amd64${{ contains(matrix.python-arch, 'x86') && '_x86' || '' }}
+#        toolset: ${{ matrix.msvc-toolset }}
+
+    - name: Install Qt
+      uses: jurplel/install-qt-action@v3
+      with:
+        aqtversion: '==2.1.*'
+        version: ${{ matrix.qt-version }}
+        host: 'windows'
+        target: 'desktop'
+        arch: ${{ matrix.qt-arch }}
+        modules: 'qtscript'
+        archives: 'qtwinextras qtmultimedia qtbase'
+        tools: ${{ contains(matrix.qt-arch, 'mingw') && format('tools_mingw,qt.tools.{0}0', matrix.qt-arch) || '' }}
+
+    - name: Setup Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v4
+      with:
+        python-version: '${{ matrix.python-version }}'
+        architecture: ${{ matrix.python-arch }}
+
+    - name: Detect exact versions
+      shell: bash
+      id: versions
+      run: |
+        echo PATH=$PATH
+        set -eu
+        QT_VERSION_FULL=$($Qt5_Dir/bin/qmake -query QT_VERSION)
+        QT_VERSION_SHORT=$(cut -f 1,2 -d . <<< $QT_VERSION_FULL)
+        echo "QT_VERSION_FULL=$QT_VERSION_FULL" | tee -a $GITHUB_OUTPUT
+        echo "QT_VERSION_SHORT=$QT_VERSION_SHORT" | tee -a $GITHUB_OUTPUT
+        echo "CL=/MP" | tee -a $GITHUB_ENV #multicore parallel build for cl.exe
+
+    - name: Add Qt and MinGW to PATH
+      shell: cmd
+      run: |
+        set "ADDPATH=%Qt5_Dir%\bin"
+        ${{ contains(matrix.qt-arch, 'mingw') && format('FOR /F "tokens=1,2 delims=_" %%I IN ("{0}") DO SET "ADDPATH=%ADDPATH%;%IQTA_TOOLS%\%%J0_{1}\bin', matrix.qt-arch, contains(matrix.qt-arch, 'win32') && '32' || '64') || '' }}
+        echo PATH=%ADDPATH%;%PATH% >> %GITHUB_ENV%
+
+    - name: Build PythonQt
+      shell: cmd
+      run: |
+        qmake -query
+        qmake -Wall -d CONFIG+=release CONFIG-=debug_and_release CONFIG-=debug_and_release_target "PYTHONQTALL_CONFIG=${{ matrix.pythonqtall-config }}" "PYTHON_PATH=%pythonLocation%" -after "QMAKE_SH=" "QMAKE_LINK_OBJECT_MAX=100" PythonQt.pro
+        mingw32-make -j 2 && mingw32-make check "TESTARGS=-platform offscreen" || nmake && nmake check "TESTARGS=-platform offscreen"
+
+    - name: Generate Wrappers
+      shell: cmd
+      run: |
+        cd generator
+        rem Workaround to allow to find the Qt include dirs for installed standard qt packages
+        set QTDIR=%Qt5_Dir%
+        set PATH=%Qt5_Dir%\bin;%PATH%
+        pythonqt_generator
+
+    - name: Upload Wrappers
+      if: false
+      uses: actions/upload-artifact@v3
+      with:
+        name: wrappers_${{ matrix.qt-arch }}_${{ steps.versions.outputs.QT_VERSION_SHORT }}
+        path: generated_cpp

build/python.prf

@@ -5,16 +5,43 @@
 isEmpty( PYTHON_VERSION ) {
   PYTHON_VERSION=$$(PYTHON_VERSION)
 }
-isEmpty( PYTHON_VERSION ) {
-  win32:PYTHON_VERSION=27
-  unix:PYTHON_VERSION=2.7
+
+isEmpty(PYTHON_DIR):PYTHON_DIR=$$(PYTHON_DIR)
+!isEmpty(PYTHON_DIR):error(Use PYTHON_PATH to choose exact Python installation instead of PYTHON_DIR)
+
+isEmpty( PYTHON_PATH ) {
+  PYTHON_PATH=$$(PYTHON_PATH)
+}
+
+!isEmpty( PYTHON_PATH ) {
+  PYTHON_PATH=$$system_path($${PYTHON_PATH}$${QMAKE_DIR_SEP})
 }
 
-isEmpty( PYTHON_DIR ) {
-  PYTHON_DIR=$$(PYTHON_DIR)
+isEmpty(PYTHON_CMD):PYTHON_CMD=$$(PYTHON_CMD)
+isEmpty(PYTHON_CMD):PYTHON_CMD=python
+!isEmpty(PYTHON_PATH):PYTHON_CMD=$${PYTHON_PATH}$${QMAKE_DIR_SEP}$${PYTHON_CMD}
+contains(QMAKE_HOST.os, Windows):PYTHON_CMD=$${PYTHON_CMD}.exe
+PYTHON_CMD=$$system_path($$PYTHON_CMD)
+!isEmpty(PYTHON_PATH):!exists($$PYTHON_CMD):error("Incorrect PYTHON_PATH was set, missing $$PYTHON_CMD")
+
+isEmpty(PYTHON_PATH): PYTHON_PATH=$$system($$system_quote($${PYTHON_CMD}) -c \
+$$system_quote(import os;import sys;print(os.path.dirname(sys.executable))))$${QMAKE_DIR_SEP}
+
+#Not just "python --version" because Python 2 outputs `--version` to the stderr
+#And there is no simple way known for me to generally redirect stderr to stdout
+PYTHON_VERSION_DETECTED=$$system($$system_quote($${PYTHON_CMD}) -c $$system_quote(import sysconfig;print(sysconfig.get_python_version())))
+
+
+isEmpty( PYTHON_VERSION ) {
+   warning(PYTHON_VERSION should be set explicitly from qmake command-line or via environment.\
+   $$escape_expand(\\n\\t) F.e.: $$shell_quote(qmake PYTHON_VERSION=3.6 CONFIG+=release) \
+		       or $$shell_quote(set PYTHON_VERSION=2.7))
+   message(Trying $${PYTHON_CMD} executable to guess the version)
+   PYTHON_VERSION=$$PYTHON_VERSION_DETECTED
 }
-!isEmpty( PYTHON_DIR ) {
-  PYTHON_DIR=$${PYTHON_DIR}/
+
+!equals(PYTHON_VERSION, $$PYTHON_VERSION_DETECTED){
+   error("Found Python version $$PYTHON_VERSION_DETECTED, but $$PYTHON_VERSION was requested")
 }
 
 PYTHON_VERSION_MAJOR=$$section(PYTHON_VERSION, ., 0, 0)
@@ -26,18 +53,22 @@ PYTHON_VERSION_MINOR=$$section(PYTHON_VERSION, ., 1, 1)
   message(Using Python version $${PYTHON_VERSION})
 }
 
-
 # Python 2.x has problems:
 # 1) https://wiki.gentoo.org/wiki/Project:Python/Strict_aliasing
 # 2) deprecated implicit cast of string literals to char*
-equals(PYTHON_VERSION_MAJOR, 2):gcc:QMAKE_CXXFLAGS *= -fno-strict-aliasing -Wno-error=write-strings
+equals(PYTHON_VERSION_MAJOR, 2) {
+   gcc:QMAKE_CXXFLAGS *= -fno-strict-aliasing -Wno-error=write-strings
+   # Qt 5.4 adds this option, but this is not compatible with the Python API
+   msvc: QMAKE_CXXFLAGS -= -Zc:strictStrings
+}
+
 contains(PKGCONFIG, "python.*"){
   CONFIG += link_pkgconfig
   PYTHON_PKGCONFIG = $$member($$unique($$find(PKGCONFIG, "python.*")), 1, 1)
   # add rpath
   PYTHON_LIBDIR = $$system($$pkgConfigExecutable() --libs-only-L $$PYTHON_PKGCONFIG)
   QMAKE_RPATHDIR += $$replace(PYTHON_LIBDIR,-L,)
-} else:macx:isEmpty(PYTHON_DIR){
+} else:macx:isEmpty(PYTHON_PATH){
   # for macx you need to have the Python development kit installed as framework
   INCLUDEPATH += /System/Library/Frameworks/Python.framework/Headers
   LIBS += -F/System/Library/Frameworks -framework Python
@@ -63,13 +94,21 @@ contains(PKGCONFIG, "python.*"){
     DEBUG_EXT = 
   }
 
-  win32:INCLUDEPATH += $$(PYTHON_PATH)/PC $$(PYTHON_PATH)/include
-  win32:LIBS += $$(PYTHON_LIB)/python$${PYTHON_VERSION}$${DEBUG_EXT}.lib
+  INCLUDEPATH += $$system($$system_quote($${PYTHON_CMD}) -c \
+		$$system_quote(import sysconfig;print(\'\"%s\" \"%s\"\'%(sysconfig.get_paths()[\'include\'],sysconfig.get_paths()[\'platinclude\']))))
+
+
+  LIBS += -L$${PYTHON_PATH}libs
+  LIBS += -lpython$${PYTHON_VERSION_MAJOR}$${PYTHON_VERSION_MINOR}
+
+  # Hack for "CONFIG+=testcase" and 'make check' to add python's dll to PATH
+  deppath += $$PYTHON_PATH
+
 } else:unix {
   # on linux, python-config is used to autodetect Python.
   # make sure that you have installed a matching python-dev package.
 
-  PYTHON_CONFIG = $${PYTHON_DIR}/bin/python$${PYTHON_VERSION}-config
+  PYTHON_CONFIG = $${PYTHON_PATH}python$${PYTHON_VERSION}-config
   PYTHON_CONFIG_OPTIONS_LIBS = --libs
   equals(PYTHON_VERSION_MAJOR, 3):!lessThan(PYTHON_VERSION_MINOR, 8) {
     # Since 3.8 `--embed` is needed

extensions/PythonQt_QtAll/PythonQt_QtAll.pro

@@ -74,6 +74,7 @@ defineTest(Xinclude) {
 PythonQtCore {
   DEFINES += PYTHONQT_WITH_CORE
   Xinclude (com_trolltech_qt_core)
+  QT += core
 }
 
 PythonQtGui  {
@@ -85,7 +86,7 @@ PythonQtGui  {
 PythonQtSvg {
   DEFINES += PYTHONQT_WITH_SVG
   Xinclude (com_trolltech_qt_svg)
-  QT +=svg
+  QT += svg
 }
 
 PythonQtSql {

src/PythonQt.cpp

@@ -2426,7 +2426,6 @@ QString PythonQtPrivate::getSignature(PyObject* object)
           Py_DECREF(s);
         }
       }
-        
       QStringList arguments;
       QStringList defaults;
       QString varargs;

src/src.pri

@@ -5,7 +5,13 @@ INCLUDEPATH += $$PWD
 CONFIG += c++11
 
 gcc:!no_warn {
-    !clang:QMAKE_CXXFLAGS += -Werror -Wno-error=missing-field-initializers
+    !clang:QMAKE_CXXFLAGS += -Wno-error=missing-field-initializers
+    #equals(QT_MAJOR_VERSION,5):lessThan(QT_MINOR_VERSION,12) {
+	#for backward compatibility, otherwise newer options cause old GCC to fail
+	# But -Wno-... is allowed by GCC for backward compatibility
+	# https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
+	#QMAKE_CXXFLAGS += -Wno-deprecated-copy
+    #}
     clang:QMAKE_CXXFLAGS += -Wno-error=sometimes-uninitialized
 }
 

src/src.pro

@@ -7,7 +7,6 @@
 TARGET   = PythonQt-Qt5-PythonXY
 TEMPLATE = lib
 
-
 DESTDIR    = ../lib
 
 CONFIG += qt
@@ -31,9 +30,6 @@ DEFINES += PYTHONQT_CATCH_ALL_EXCEPTIONS
 contains(QT_MAJOR_VERSION, 5) {
   QT += widgets core-private
 }
-
-# Qt 5.4 adds this option, but this is not compatible with the Python API
-QMAKE_CXXFLAGS_RELEASE -= -Zc:strictStrings
 
 INCLUDEPATH += $$PWD