fixes for lgtm alerts

Signed-off-by: prakashngit <[email protected]>

Author: prakashngit

python/pdo/common/keys.py

@@ -50,6 +50,8 @@ def read_transaction_keys_from_file(key_file, search_path, \
     else:
         raise Exception("Invalid Ledger Type. Must be either 'sawtooth' or 'ccf'")
 
+    return txn_keys
+
 # -----------------------------------------------------------------
 # -----------------------------------------------------------------
 class TransactionKeys(object) :

python/pdo/contract/contract.py

@@ -15,8 +15,6 @@
 import errno
 import json
 
-import pdo.common.crypto as crypto
-import pdo.common.keys as keys
 import pdo.common.utility as putils
 
 from pdo.submitter.create import create_submitter

python/pdo/service_client/service_data/eservice.py

@@ -43,7 +43,6 @@
 from pdo.submitter.create import create_submitter
 from pdo.service_client.enclave import EnclaveServiceClient
 from pdo.common.utility import deprecated
-import pdo.common.keys as keys
 
 # -----------------------------------------------------------------
 # -----------------------------------------------------------------

python/pdo/submitter/ccf/ccf_submitter.py

@@ -19,7 +19,6 @@
 
 import pdo.submitter.ccf.helpers.clients as ccf_helper
 
-import pdo.common.utility as putils
 import pdo.common.crypto as crypto
 import pdo.common.keys as keys
 import pdo.submitter.submitter as sub
@@ -64,7 +63,7 @@ def __init__(self, ledger_config, *args, **kwargs):
                 _, host_port = self.url.split('//')
                 self.host, self.port = host_port.split(':')
             except Exception as e:
-                raise("Unable to parse CCF ledger URL. Must be of the form http://ip:port : %s", str(e))
+                raise Exception("Unable to parse CCF ledger URL. Must be of the form http://ip:port : %s", str(e))
 
             ccf_key_dir = os.environ.get("PDO_LEDGER_KEY_ROOT")
             #ensure that ccf keys are present

python/pdo/submitter/sawtooth/helpers/pdo_connect.py

@@ -13,7 +13,6 @@
 # limitations under the License.
 
 import logging
-import hashlib
 import time
 import requests
 import yaml
@@ -22,7 +21,6 @@
 import binascii
 import warnings
 import secp256k1
-import urllib
 
 from google.protobuf import json_format
 from google.protobuf.json_format import MessageToDict
@@ -44,9 +42,7 @@
     PdoContractTransaction,\
     PdoContractRegister,\
     PdoContractAddEnclaves,\
-    PdoContractRemoveEnclaves,\
-    PdoContractEnclavesInfo,\
-    PdoProvisioningKeyToStateSecretMap
+    PdoContractRemoveEnclaves
 
 from  pdo.submitter.sawtooth.pdo_protos.pdo_contract_ccl_pb2 import\
     CCL_ContractState,\

python/pdo/submitter/submitter.py

@@ -14,7 +14,6 @@
 
 import json
 import logging
-import os
 from abc import ABCMeta, abstractmethod
 
 logger = logging.getLogger(__name__)