Improve can't find conpty.dll exception message

Tyriar · Tyriar · commit 98d856617191 · 2024-08-05T08:21:32.000-07:00
Part of microsoft/vscode#224488
diff --git a/src/win/conpty.cc b/src/win/conpty.cc
@@ -179,7 +179,9 @@ HANDLE LoadConptyDll(const Napi::CallbackInfo& info,
 
   std::wstring conptyDllPath = currentDirStr + L"\\build\\Release\\conpty\\conpty.dll";
   if (!path_util::file_exists(conptyDllPath)) {
-    throw errorWithCode(info, "Cannot find conpty.dll");
+    std::wstring errorMessage = L"Cannot find conpty.dll at " + conptyDllPath;
+    std::string errorMessageStr(errorMessage.begin(), errorMessage.end());
+    throw errorWithCode(info, errorMessageStr.c_str());
   }
 
   return LoadLibraryW(conptyDllPath.c_str());

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,9 @@ HANDLE LoadConptyDll(const Napi::CallbackInfo& info,`
`179`	`179`
`180`	`180`	`std::wstring conptyDllPath = currentDirStr + L"\\build\\Release\\conpty\\conpty.dll";`
`181`	`181`	`if (!path_util::file_exists(conptyDllPath)) {`
`182`		`- throw errorWithCode(info, "Cannot find conpty.dll");`
	`182`	`+ std::wstring errorMessage = L"Cannot find conpty.dll at " + conptyDllPath;`
	`183`	`+ std::string errorMessageStr(errorMessage.begin(), errorMessage.end());`
	`184`	`+ throw errorWithCode(info, errorMessageStr.c_str());`
`183`	`185`	`}`
`184`	`186`
`185`	`187`	`return LoadLibraryW(conptyDllPath.c_str());`