Skip to content

Commit 64442fc

Browse files
committed
Merge pull request #1226 from geraldus/g/fix-circular-deps
Move haskell-interactive-prompt-state related definitions to haskell-utils.el
2 parents cc22219 + 07e9667 commit 64442fc

9 files changed

+21
-16
lines changed

haskell-cabal.el

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151

5252
(require 'cl-lib)
5353
(require 'haskell-utils)
54-
(require 'haskell-mode)
5554

5655
(defconst haskell-cabal-general-fields
5756
;; Extracted with (haskell-cabal-extract-fields-from-doc "general-fields")

haskell-debug.el

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
(require 'haskell-process)
2424
(require 'haskell-interactive-mode)
2525
(require 'haskell-font-lock)
26+
(require 'haskell-utils)
2627

2728
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
2829
;; Configuration

haskell-doc.el

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,7 @@
305305
(require 'haskell-mode)
306306
(require 'haskell-process)
307307
(require 'haskell)
308+
(require 'haskell-utils)
308309
(require 'inf-haskell)
309310
(require 'imenu)
310311
(require 'eldoc)

haskell-hoogle.el

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828

2929
(require 'ansi-color)
3030
(require 'haskell-mode)
31+
(require 'haskell-utils)
3132

3233

3334
(defcustom haskell-hoogle-command

haskell-interactive-mode.el

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
(require 'haskell-session)
3737
(require 'haskell-font-lock)
3838
(require 'haskell-presentation-mode)
39+
(require 'haskell-utils)
3940

4041
(require 'ansi-color)
4142
(require 'cl-lib)

haskell-load.el

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
(require 'haskell-modules)
2727
(require 'haskell-commands)
2828
(require 'haskell-session)
29+
(require 'haskell-utils)
2930

3031
(defun haskell-process-look-config-changes (session)
3132
"Check whether a cabal configuration file has changed.

haskell-mode.el

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -663,10 +663,6 @@ May return a qualified name."
663663

664664
(defvar eldoc-print-current-symbol-info-function)
665665

666-
(defvar haskell-mode-interactive-prompt-state nil
667-
"Special variable indicating a state of user input waiting.")
668-
669-
670666
;; The main mode functions
671667
;;;###autoload
672668
(define-derived-mode haskell-mode prog-mode "Haskell"
@@ -1073,12 +1069,6 @@ successful, nil otherwise."
10731069
(goto-char (point-min))
10741070
(end-of-line)))
10751071

1076-
(defun haskell-mode-toggle-interactive-prompt-state (&optional disabled)
1077-
"Set `haskell-mode-interactive-prompt-state' to t.
1078-
If given DISABLED argument sets variable value to nil, otherwise to t."
1079-
(setq haskell-mode-interactive-prompt-state (not disabled)))
1080-
1081-
10821072
;; Provide ourselves:
10831073

10841074
(provide 'haskell-mode)

haskell-utils.el

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,22 @@
3535

3636
;;; Code:
3737

38-
;; NOTE: This module is supposed to be a leaf-module and shall not
39-
;; require/depend-on any other haskell-mode modules in order to
40-
;; stay at the bottom of the module dependency graph.
38+
;; =============================================================================
39+
;; NOTE:
40+
;; THIS MODULE IS SUPPOSED TO BE A LEAF-MODULE AND SHALL NOT REQUIRE/DEPEND-ON
41+
;; ANY OTHER HASKELL-MODE MODULES IN ORDER TO STAY AT THE BOTTOM OF THE MODULE
42+
;; DEPENDENCY GRAPH.
43+
;; =============================================================================
4144

4245
(eval-when-compile (require 'cl-lib))
4346

44-
(require 'haskell-customize)
45-
4647
(defvar haskell-utils-async-post-command-flag nil
4748
"Non-nil means some commands were triggered during async function execution.")
4849
(make-variable-buffer-local 'haskell-utils-async-post-command-flag)
4950

51+
(defvar haskell-mode-interactive-prompt-state nil
52+
"Special variable indicating a state of user input waiting.")
53+
5054
(defun haskell-utils-read-directory-name (prompt default)
5155
"Read directory name and normalize to true absolute path.
5256
Refer to `read-directory-name' for the meaning of PROMPT and
@@ -180,5 +184,11 @@ expression bounds."
180184
end-c
181185
value)))))
182186

187+
188+
(defun haskell-mode-toggle-interactive-prompt-state (&optional disabled)
189+
"Set `haskell-mode-interactive-prompt-state' to t.
190+
If given DISABLED argument sets variable value to nil, otherwise to t."
191+
(setq haskell-mode-interactive-prompt-state (not disabled)))
192+
183193
(provide 'haskell-utils)
184194
;;; haskell-utils.el ends here

tests/haskell-doc-tests.el

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
(require 'haskell-mode)
3232
(require 'haskell-doc)
3333
(require 'haskell-test-utils)
34+
(require 'haskell-utils)
3435

3536

3637
(ert-deftest interactive-prompt-state ()

0 commit comments

Comments
 (0)