Skip to content

pre-commit hook is failing locally and on CI #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andys8 opened this issue Sep 15, 2022 · 2 comments
Closed

pre-commit hook is failing locally and on CI #3170

andys8 opened this issue Sep 15, 2022 · 2 comments
Labels
status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@andys8
Copy link
Collaborator

andys8 commented Sep 15, 2022

All open pull requests have a failing CI job because "pre-commit" will result in errors.

image

Solving the root cause or if not possible disabling the job for now would be great in order to avoid confusion (especially for new contributors)

Steps to reproduce

Run CI, open a PR

Example: https://github.com/haskell/haskell-language-server/actions/runs/3060016524/jobs/4938045479

Reasons

Stylish Haskell fails to parse some files

See #3131 and #3171

CI
ghcide/src/Development/IDE/GHC/Compat/Plugins.hs: <string>:53:3: error:
    parse error (possibly incorrect indentation or mismatched brackets)
ghcide/src/Development/IDE/GHC/Compat/Env.hs: <string>:101:1: error: parse error on input `import'
Locally (stylish-haskell 0.14.2.0)
ghcide/src/Development/IDE/GHC/Compat/Plugins.hs: <string>:53:3: error:
    parse error (possibly incorrect indentation or mismatched brackets)
plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction/ExactPrint.hs: <string>:7:1: error: parse error on input `#'
ghcide/src/Development/IDE/GHC/Compat/Env.hs: <string>:101:1: error: parse error on input `import'
plugins/hls-refactor-plugin/src/Development/IDE/GHC/Compat/ExactPrint.hs: <string>:5:1: error: parse error on input `#'
plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs: <string>:90:1: error: parse error on input `#'

Some files are not formatted

Fixed with #3171

@andys8 andys8 added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. status: needs triage labels Sep 15, 2022
@andys8
Copy link
Collaborator Author

andys8 commented Sep 19, 2022

@andys8
Copy link
Collaborator Author

andys8 commented Sep 19, 2022

CI passing

#3199 (comment)

@andys8 andys8 closed this as completed Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

1 participant